Re: Add a GUI for dxdiag program

[Aaryaman Vasishta]

Hi,

Thanks for your patch!
I see there are still many style inconsistencies here, like "foo=bar;" and
"foo = bar;" mixed together. Same for passing arguments, like
"foo(bar,baz)" and "foo(bar, baz)" mixed together. Please try sticking to a
single convention, it helps in code readability. There also might be an
issue with the consistency of indendation on longer lines which do not fit.
As long as you keep the indentation levels consistent across the file you
should be fine.

On Sat, Aug 27, 2016 at 1:56 PM, Ruslan Kabatsayev 
wrote:
> +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam,
> LPARAM lparam)
> +{
> - switch(msg)
> - {
> - case WM_COMMAND:
> -
>    switch(HIWORD(wparam))
> -
>    {
> -
>    case BN_CLICKED:
> -
>        switch(wparam)
> -
>        {
> -
>        case IDC_WHQL_CHECKBOX:
> -
>        {
> -
>            update_dxdiag_info();
> -
>            return TRUE;
> -
>        }
> -
>        }
> -
>        break;

There's an indentation issue here.

You should still wait for others to review this before re-sending this
patch though.

Cheers,
Aaryaman

Add a GUI for dxdiag program

[Ruslan Kabatsayev]

On Sat, Aug 27, 2016 at 12:31 PM, Aaryaman Vasishta
 wrote:
> > +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam,
> > LPARAM lparam)
> > +{
> > - switch(msg)
> > - {
> > - case WM_COMMAND:
> > -
> >    switch(HIWORD(wparam))
> > -
> >    {
> > -
> >    case BN_CLICKED:
> > -
> >        switch(wparam)
> > -
> >        {
> > -
> >        case IDC_WHQL_CHECKBOX:
> > -
> >        {
> > -
> >            update_dxdiag_info();
> > -
> >            return TRUE;
> > -
> >        }
> > -
> >        }
> > -
> >        break;
>
> There's an indentation issue here.

Is there? Looking at original main.c I see that "case" labels are also
unindented there. Or do you mean something other?

Add a GUI for dxdiag program

[Aaryaman Vasishta]

On Sat, Aug 27, 2016 at 9:12 PM, Ruslan Kabatsayev 
wrote:
> On Sat, Aug 27, 2016 at 12:31 PM, Aaryaman Vasishta
>  wrote:
> > > +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam,
> > > LPARAM lparam)
> > > +{
> > > - switch(msg)
> > > - {
> > > - case WM_COMMAND:
> > > -
> > >    switch(HIWORD(wparam))
> > > -
> > >    {
> > > -
> > >    case BN_CLICKED:
> > > -
> > >        switch(wparam)
> > > -
> > >        {
> > > -
> > >        case IDC_WHQL_CHECKBOX:
> > > -
> > >        {
> > > -
> > >            update_dxdiag_info();
> > > -
> > >            return TRUE;
> > > -
> > >        }
> > > -
> > >        }
> > > -
> > >        break;
> >
> > There's an indentation issue here.
>
> Is there? Looking at original main.c I see that "case" labels are also
> unindented there. Or do you mean something other?

Ah, my bad. I didn't really look at the whole file. If it's consistent with
the rest of the file then it's fine :)

Cheers,
Aaryaman