Re: [PATCH 1/1] wined3d: Explicitly use the C locale for generating shaders.

[Alexandre Julliard]

Henri Verbeet  writes:
> Specifically, we always want to use '.' as decimal separator. Reported on IRC.

That's not very portable:

x86_64-w64-mingw32-gcc -c -I../../../wine/dlls/wined3d -I. -I../../../wine/include -I../../include  -D__WINESRC__  -D_REENTRANT -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -Wno-format  -g -O2  -o glsl_shader.o ../../../wine/dlls/wined3d/glsl_shader.c
../../../wine/dlls/wined3d/glsl_shader.c:92:5: error: unknown type name ‘locale_t’
../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_pshader’:
../../../wine/dlls/wined3d/glsl_shader.c:4695:5: warning: implicit declaration of function ‘uselocale’ [-Wimplicit-function-declaration]
../../../wine/dlls/wined3d/glsl_shader.c:4697:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function)
../../../wine/dlls/wined3d/glsl_shader.c:4697:15: note: each undeclared identifier is reported only once for each function it appears in
../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_vshader’:
../../../wine/dlls/wined3d/glsl_shader.c:4771:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function)
../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_geometry_shader’:
../../../wine/dlls/wined3d/glsl_shader.c:4811:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function)
../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_find_ffp_vertex_shader’:
../../../wine/dlls/wined3d/glsl_shader.c:5662:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function)
../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_find_ffp_fragment_shader’:
../../../wine/dlls/wined3d/glsl_shader.c:5685:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function)
../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_alloc’:
../../../wine/dlls/wined3d/glsl_shader.c:6355:5: warning: implicit declaration of function ‘newlocale’ [-Wimplicit-function-declaration]
../../../wine/dlls/wined3d/glsl_shader.c:6355:36: error: ‘LC_ALL_MASK’ undeclared (first use in this function)
../../../wine/dlls/wined3d/glsl_shader.c:6410:9: warning: implicit declaration of function ‘freelocale’ [-Wimplicit-function-declaration]
make: *** [glsl_shader.o] Error 1

[PATCH 1/1] wined3d: Explicitly use the C locale for generating shaders.

[Henri Verbeet]

On 10 June 2013 12:40, Alexandre Julliard  wrote:
> Henri Verbeet  writes:
> > Specifically, we always want to use '.' as decimal separator. Reported on IRC.
>
> That's not very portable:

POSIX.1-2008, supposedly. I'm not aware of a more portable way to do
this, although I could add wrappers to just do nothing when these are
not available, if that helps.

[PATCH 1/1] wined3d: Explicitly use the C locale for generating shaders.

[Alexandre Julliard]

Henri Verbeet  writes:
> On 10 June 2013 12:40, Alexandre Julliard  wrote:
> > Henri Verbeet  writes:
> > > Specifically, we always want to use '.' as decimal separator. Reported on IRC.
> >
> > That's not very portable:
>
> POSIX.1-2008, supposedly. I'm not aware of a more portable way to do
> this, although I could add wrappers to just do nothing when these are
> not available, if that helps.

Writing a helper function to format floats in a non locale-dependent way
would probably be a better idea.