Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4650
Your paranoid android.
=== WVISTAADM (32 bit image) === No test summary line found
=== W7PRO (32 bit image) === image.c:103: Test failed: Expected 00012010, got 00013010 image.c:103: Test failed: Expected 00013088, got 00013010
=== W7PROX64 (32 bit image) === image.c:103: Test failed: Expected 00012010, got 00013010 image.c:103: Test failed: Expected 00013088, got 00013010
=== W7PROX64 (64 bit image) === image.c:103: Test failed: Expected 00012010, got 00013010 image.c:103: Test failed: Expected 00013088, got 00013010
Yep, this patch should not be committed.
So the flags for a loaded image on Windows 7 are always 13010. So while earlier versions of gdiplus could determine whether the DPI was set in an image header, win7's gdiplus cannot, and always claims that it is.
I remember reading that gdiplus on win7 uses WIC for its image loading/saving, and I know that WIC cannot get this information. So it makes sense.
It's also very convenient for me.
On Sun, Aug 22, 2010 at 1:42 PM, Marvin testbot@testbot.winehq.org wrote:
-
testbot＠testbot.winehq.org -
Vincent Povirk