Re: [try 2] Test for window messages of a property sheet with custom dialog proc (bug 12104)
On 11/06/2010 11:16 AM, Bernhard Übelacker wrote:
Hello, this patch checks for correct arrival of messages to a subclassed property page.
For this bug http://bugs.winehq.org/show_bug.cgi?id=12104 specifically the first WM_SIZE message is interesting which is not sent in wine.
I have changed the patch based on the feedback I got on my first mail. (http://www.winehq.org/pipermail/wine-devel/2010-October/087474.html)
Now I am using the msg.h facilities for checking the messages.
Kind regards, Bernhard
Hi,
Ever since this patch the shell32:shlexec tests fail on NT4 and W2K:
http://test.winehq.org/data/tests/shell32:shlexec.html
I can reproduce easily by running (on a clean Windows box):
winetest-latest.exe comctl32:propsheet shell32:shlexec
This will throw some error dialog boxes and I'm also unable to double-click items in the "Windows Explorer".
Thoughts/Ideas/Suggestions?
Am Donnerstag 11 November 2010 schrieben Sie:
On 11/06/2010 11:16 AM, Bernhard Übelacker wrote:
Hello, this patch checks for correct arrival of messages to a subclassed property page.
For this bug http://bugs.winehq.org/show_bug.cgi?id=12104 specifically the first WM_SIZE message is interesting which is not sent in wine.
I have changed the patch based on the feedback I got on my first mail. (http://www.winehq.org/pipermail/wine-devel/2010-October/087474.html)
Now I am using the msg.h facilities for checking the messages.
Kind regards, Bernhard
Hi,
Ever since this patch the shell32:shlexec tests fail on NT4 and W2K:
http://test.winehq.org/data/tests/shell32:shlexec.html
I can reproduce easily by running (on a clean Windows box):
winetest-latest.exe comctl32:propsheet shell32:shlexec
This will throw some error dialog boxes and I'm also unable to double-click items in the "Windows Explorer".
Thoughts/Ideas/Suggestions?
Hello, I can also reproduce this on a nt4 virtualbox.
When running an older winetest-latest from 2010-11-05 [1] then there is already a crash in explorer.exe happening.
When running a winetest-latest from 2010-11-08 [2] there is this crash also but then winetest-shell "sleeps some time". After this for example a double click on my computer does not open an explorer window.
When I run both tests as single files from a "make crosstest" I was not able to reproduce neither the explorer crash or the explorer windows not opening.
Can someone provide some pointers how the winetest-latest.exe at the testbot is built?
[1] http://testbot.winehq.org/JobDetails.pl?Key=6831#k104 [2] http://testbot.winehq.org/JobDetails.pl?Key=6895#k104
Kind regards, Bernhard
On 11/13/2010 10:59 AM, Bernhard Übelacker wrote:
When I run both tests as single files from a "make crosstest" I was not able to reproduce neither the explorer crash or the explorer windows not opening.
I didn't see a crash but maybe this is because I'm testing on W2K. I can still reliably get the double-clicking out of order when just running the cross-compiled comctl32 tests ('make crosstest' on my own box).
There is also something 'fundamentally' wrong with the tests:
+ hdlg = (HWND)PropertySheetA(&psh); + if (hdlg == INVALID_HANDLE_VALUE) + { + win_skip("comctl32 4.70 needs dwSize adjustment\n"); + psh.dwSize = sizeof(psh) - sizeof(HBITMAP) - sizeof(HPALETTE) - sizeof(HBITMAP); + hdlg = (HWND)PropertySheetA(&psh); + } + ShowWindow(hdlg,SW_NORMAL); + + ok_sequence(sequences, PROPSHEET_SEQ_INDEX, property_sheet_seq, "property sheet with custom window proc", TRUE); + + DestroyWindow(hdlg);
The PropertySheet call will create a modal (not a modeless) property sheet and thus the return value is not a handle (see also MSDN). You can easily check by adding some traces (see http://testbot.winehq.org/JobDetails.pl?Key=7013). hdlg is always 0 and destroying the window will give you an error ERROR_INVALID_WINDOW_HANDLE.
Will investigate further but any help is welcome.
-
Bernhard Übelacker -
Paul Vriens