P.S.: Alexandre, I'd REALLY like you to finally put a patch status tracking system in place. The number of people submitting patches for the second, third, bazillionth time is astonishing (I speak from my very own experience, too!). I really don't know how many very valuable Wine patches got lost due to not getting applied without any status reply whatsoever...
The main problem as far as I'm concerned isn't so much the lack of a patch "tracker", I'm usually capable of keeping track of whether my patches have been applied or not by watching wine-cvs (though i've found once or twice i've missed the commit), it's more an issue of if a patch is rejected, you have to ask why.
That means I'm often left thinking, is my patch simply in the queue, or is something wrong with it? Or, like my last pkgconfig patch, is there another reason it didn't go in?
The way gnome/mozilla do it is to have patches put in bugzilla, but for the sheer volume of patches Wine gets with only Alexandre committing (which is fine by me), that wouldn't work.
I'd be perfectly happy with the current arrangement if when a patch was dropped, a reason would normally appear on wine-devel - but then I'm not the one doing the work, Alexandre is, so it's easy for me to ask for him to do more work :/
thanks -mike
On Sun, Apr 13, 2003 at 01:05:19PM +0100, Mike Hearn wrote:
P.S.: Alexandre, I'd REALLY like you to finally put a patch status tracking system in place. The number of people submitting patches for the second, third, bazillionth time is astonishing (I speak from my very own experience, too!). I really don't know how many very valuable Wine patches got lost due to not getting applied without any status reply whatsoever...
The main problem as far as I'm concerned isn't so much the lack of a patch "tracker", I'm usually capable of keeping track of whether my patches have been applied or not by watching wine-cvs (though i've found once or twice i've missed the commit), it's more an issue of if a patch is rejected, you have to ask why.
That means I'm often left thinking, is my patch simply in the queue, or is something wrong with it? Or, like my last pkgconfig patch, is there another reason it didn't go in?
The way gnome/mozilla do it is to have patches put in bugzilla, but for the sheer volume of patches Wine gets with only Alexandre committing (which is fine by me), that wouldn't work.
I'd be perfectly happy with the current arrangement if when a patch was dropped, a reason would normally appear on wine-devel - but then I'm not the one doing the work, Alexandre is, so it's easy for me to ask for him to do more work :/
I occasionaly rediff my whole tree and so notice if a patch is missing, and I remember if I sent it or not.
And I meanwhile understand Alexandres acceptance rules pretty well to know that a slightly hacky patch will just not make it in ;)
So I do not see a real problem here ;)
Ciao, Marcus
I occasionaly rediff my whole tree and so notice if a patch is missing, and I remember if I sent it or not.
I would but I tend to add debug code etc which pollutes the diff - I just keep a small text file with a record of every patch i make, then delete it when its committed, works fine for me.
And I meanwhile understand Alexandres acceptance rules pretty well to know that a slightly hacky patch will just not make it in ;)
Ah, but you can been working with Alexandre for years, not months like me. I expect you have a far better feel for when a patch is dropped because it's too hacky, or for when the code style isn't right and so on.....
So I do not see a real problem here ;)
It's not huge, Alexandre has always explained when I've asked why a patch didn't go in and he's always reasonable. I expect for some patches though, people send them and assume they'll be told if there's a problem then it just gets forgotten about over time.
Ciao, Marcus
-
Marcus Meissner -
Mike Hearn