Re: d3d8: Void functions should not return a value

[Eric Pouech]

Andrew Talbot a écrit :
> These functions are correctly declared to return nothing, so that's what they
> should do.
> -- Andy.
>
> Changelog:
>     d3d8: Void functions should not return a value.
>
> diff -urN a/dlls/d3d8/cubetexture.c b/dlls/d3d8/cubetexture.c
> --- a/dlls/d3d8/cubetexture.c	2006-12-06 11:51:13.000000000 +0000
> +++ b/dlls/d3d8/cubetexture.c	2007-04-07 20:35:00.000000000 +0100
> @@ -104,7 +104,8 @@
>  static void WINAPI IDirect3DCubeTexture8Impl_PreLoad(LPDIRECT3DCUBETEXTURE8 iface) {
>      IDirect3DCubeTexture8Impl *This = (IDirect3DCubeTexture8Impl *)iface;
>      TRACE("(%p) Relay\n", This);
> - return IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture);
> - IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture);
> - return;
>
> }

I don't see the point of still having "return;" as last statement of 
function. It can be safely removed
A+

d3d8: Void functions should not return a value

[Andrew Talbot]

On Saturday 07 April 2007 21:00, Eric Pouech wrote:
> I don't see the point of still having "return;" as last statement of 
> function. It can be safely removed
> A+

Thanks, Eric. I've now posted a return-less version.

--
Andy.