Re: advapi32/tests: Skip tests for ACL file info if ACL info not stored (try 2)

[Alexandre Julliard]

Austin Lund  writes:
> @@ -3143,6 +3146,13 @@ static void test_GetSecurityInfo(void)
>          return;
>      }
> - if (GetVolumePathName(myARGV[0], volumepathname, 50) &&
> -
>    GetVolumeInformation(volumepathname, NULL, 0, NULL, NULL, &filesystemflags, NULL, 0) &&
> -
>    (filesystemflags & FILE_PERSISTENT_ACLS))
> - {
> -
>    testacl = TRUE;
> - }

Testing file system flags is not a good idea, that won't work on
Wine. It's better to test the results of the actual call.

advapi32/tests: Skip tests for ACL file info if ACL info not stored (try 2)

[Austin Lund]

2009/11/18 Alexandre Julliard :
> Testing file system flags is not a good idea, that won't work on
> Wine. It's better to test the results of the actual call.

The reason this test fails for me is because I have a FAT32 volume and
there is no ACL info stored, so the tests:

ok(dacl != NULL, "GetSecurityInfo\n");
    ok(IsValidAcl(dacl), "GetSecurityInfo\n");

clearly will fail.  Unless there is another way to find out if the ACL
information is persistent, then the only option left is to remove
these tests otherwise they will always fail when running on a FAT32
drive.

advapi32/tests: Skip tests for ACL file info if ACL info not stored (try 2)

[Alexandre Julliard]

Austin Lund  writes:
> 2009/11/18 Alexandre Julliard :
> > Testing file system flags is not a good idea, that won't work on
> > Wine. It's better to test the results of the actual call.
>
> The reason this test fails for me is because I have a FAT32 volume and
> there is no ACL info stored, so the tests:
> ok(dacl != NULL, "GetSecurityInfo\n");
> ok(IsValidAcl(dacl), "GetSecurityInfo\n");
>
> clearly will fail.  Unless there is another way to find out if the ACL
> information is persistent, then the only option left is to remove
> these tests otherwise they will always fail when running on a FAT32
> drive.

That doesn't mean you have to remove it all, just don't treat the case
of dacl being NULL as an error.