Re: [PATCH 1/2] wined3d: Put local constants into the shader code again

[Henri Verbeet]

On 13 March 2013 02:19, Stefan Dösinger  wrote:
> This provides a small GPU-side performance boost on dx10+ capable Nvidia
> cards - about 5% in World of Tanks on my Geforce 9600, and more in a
> dedicated test program.
>
> This is essentially a revert of cd7825c89374fb9dd4c20aef2dbfd258713efe6a,
> with proper precision.

This is probably ok, although one concern is applications setting
constants to e.g. NaN or infinity. It may be worth using
ARB_shader_bit_encoding when available, or perhaps even only doing
this when that extension is available.

[PATCH 1/2] wined3d: Put local constants into the shader code again

[Stefan Dösinger]

Henri Verbeet  schrieb:
> This is probably ok, although one concern is applications setting
> constants to e.g. NaN or infinity. It may be worth using
> ARB_shader_bit_encoding when available, or perhaps even only doing
> this when that extension is available.

I'll do some testing on that, please skip the patch for now.