updating spec files - which windows version to use?

[Austin English]

Howdy,

I was looking at http://bugs.winehq.org/show_bug.cgi?id=23421, and
wanted to add a stub for it. Using winedump on a Windows 7 shlwapi.dll
gives different exports than Windows XP SP3 shlwapi.dll. Which dll
should the spec file be updated to match? I'm assuming the latest and
greatest, since eventually applications will head that direction.

An additional related question. Some of the functions that are
ordinals in previous Windows versions are now exported (e.g.,
ParseUrlA/W seems to have been documented/exported since Vista).
Should the spec file be adjusted to match the newer behavior?

I'm assuming this will have to wait until after 1.2 to be applied...

Thanks!
Austin

[Peter Davies]

> Howdy,
>
> I was looking at http://bugs.winehq.org/show_bug.cgi?id=23421, and
> wanted to add a stub for it. Using winedump on a Windows 7 shlwapi.dll
> gives different exports than Windows XP SP3 shlwapi.dll. Which dll
> should the spec file be updated to match? I'm assuming the latest and
> greatest, since eventually applications will head that direction.
>
> An additional related question. Some of the functions that are
> ordinals in previous Windows versions are now exported (e.g.,
> ParseUrlA/W seems to have been documented/exported since Vista).
> Should the spec file be adjusted to match the newer behavior?
>
> I'm assuming this will have to wait until after 1.2 to be applied...
>
> Thanks!
> Austin

If there are no conflicts, add everything. If any version of windows
exports something, export it. Exporting ParseUrlA/W by name will work
with both XP and post-vista programs, not exporting it by name will
break post-vista programs. If a function was removed after a certain
version, it wouldn't be removed in wine.

Peter