Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.

[Christian Costa]

Le 02/04/2012 00:03, Michael Stefaniuc a écrit :
> -static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime (LPDIRECTMUSICPERFORMANCE8 iface, MUSIC_TIME mtTime, REFERENCE_TIME* prtTime) {
> - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface;
>
> +static HRESULT WINAPI IDirectMusicPerformance8Impl_MusicToReferenceTime(IDirectMusicPerformance8 *iface,
> -
>    MUSIC_TIME mtTime, REFERENCE_TIME *prtTime)
>
> +{
> -
>    IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface);
> - FIXME("(%p, %d, %p): stub\n", This, mtTime, prtTime);
>  return S_OK;
> }
>
> -static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime (LPDIRECTMUSICPERFORMANCE8 iface, REFERENCE_TIME rtTime, MUSIC_TIME* pmtTime) {
> - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface;
>
> +static HRESULT WINAPI IDirectMusicPerformance8Impl_ReferenceToMusicTime(IDirectMusicPerformance8 *iface,
> -
>    REFERENCE_TIME rtTime, MUSIC_TIME *pmtTime)
>
> +{
> -
>    IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface);
> - FIXME("(%p, 0x%s, %p): stub\n", This, wine_dbgstr_longlong(rtTime), pmtTime);
>  return S_OK;
> }
>
> -static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying (LPDIRECTMUSICPERFORMANCE8 iface, IDirectMusicSegment* pSegment, IDirectMusicSegmentState* pSegState) {
> - IDirectMusicPerformance8Impl *This = (IDirectMusicPerformance8Impl *)iface;
>
> +static HRESULT WINAPI IDirectMusicPerformance8Impl_IsPlaying(IDirectMusicPerformance8 *iface,
> -
>    IDirectMusicSegment *pSegment, IDirectMusicSegmentState *pSegState)
>
> +{
> -
>    IDirectMusicPerformance8Impl *This = impl_from_IDirectMusicPerformance8(iface);
> - FIXME("(%p, %p, %p): stub\n", This, pSegment, pSegState);
>  return S_FALSE;
> }

Hi Michael,

While you're at it, could you put a 4 spaces indentation to whole method.

Christian

[PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.

[Michael Stefaniuc]

Hello Christian,

On 04/02/2012 09:05 AM, Christian Costa wrote:
> While you're at it, could you put a 4 spaces indentation to whole method.

I thought about that but that would make the patch huge and it is
already big. The re-indentation can be done when the functions get
implemented.

bye
    michael