Re: ntdll: Reduce stack usage of virtual memory functions by storing sigset in static memory.
Am 27.09.2015 um 00:07 schrieb Sebastian Lackner:
From: Michael Müller michael@fds-team.de
For https://bugs.winehq.org/show_bug.cgi?id=34558
Depending on the compiler optimization flags there is still no guarantee that everything will fit into the available stack space, no matter if its declared as static or not.
As suspected the idea does not work for all optimization levels. At least GCC merges the content of the functions when using -O2 and therefore reintroduces the problem - even __attribute__ ((noinline)) is not sufficient.
As most distributions compile Wine with -02, I would suggest to ignore the patch for now. Maybe we can come up with a more general solution.
On Sun, Sep 27, 2015 at 6:05 PM, Michael Müller michael@fds-team.de wrote:
Am 27.09.2015 um 00:07 schrieb Sebastian Lackner:
From: Michael Müller michael@fds-team.de
For https://bugs.winehq.org/show_bug.cgi?id=34558
Depending on the compiler optimization flags there is still no guarantee that everything will fit into the available stack space, no matter if its declared as static or not.
As suspected the idea does not work for all optimization levels. At least GCC merges the content of the functions when using -O2 and therefore reintroduces the problem - even __attribute__ ((noinline)) is not sufficient.
Try __attribute__ ((noclone,noinline))
Gražvydas
-
Grazvydas Ignotas -
Michael Müller