Re: [PATCH] winecfg: Use proper size for combobox controls

[Alexandre Julliard]

Fabian Maurer  writes:
> Fixes Bug 43632.
> winecfg used the broken behavior that was fixed
> in f7f7b89e2e9117811c91269643868c6d063db5e9,
> so we need to adjust it.
> Signed-off-by: Fabian Maurer
>
> programs/winecfg/winecfg.rc | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

There are resources in other modules that look like they would have the
same problem, a grep over the codebase would probably be useful.

[PATCH] winecfg: Use proper size for combobox controls

[Fabian Maurer]

> There are resources in other modules that look like they would have the
> same problem, a grep over the codebase would probably be useful.

Indeed, I'll look into it.

Regards,
Fabian Maurer

[PATCH] winecfg: Use proper size for combobox controls

[Fabian Maurer]

> > There are resources in other modules that look like they would have the
> > same problem, a grep over the codebase would probably be useful.
>
> Indeed, I'll look into it.

There are 10 other components affected. Two questions:

1) Should I only look in *.rc files or are there others to look out for?
2) Should I make one big patch or for each component one?

Regards,
Fabian Maurer

[PATCH] winecfg: Use proper size for combobox controls

[Alexandre Julliard]

Fabian Maurer  writes:
> > > There are resources in other modules that look like they would have the
> > > same problem, a grep over the codebase would probably be useful.
> >
> > Indeed, I'll look into it.
>
> There are 10 other components affected. Two questions:
> - Should I only look in *.rc files or are there others to look out for?

That's probably good enough.
> - Should I make one big patch or for each component one?

One per component please.