AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples?
I've started a list at http://wiki.winehq.org/StyleExamples
Another example: http://www.winehq.org/pipermail/wine-patches/2012-January/110398.html http://source.winehq.org/git/wine.git/commit/b1f04e23bf361e06d239e03693c904a...
I had added a redundant null check in both A and W paths. he simplified it by making just the W path handle the null
Hi,
Here's another one where AJ implemented a suggestion I sent 3 days later:
http://source.winehq.org/git/wine.git/commitdiff/5523820b810d16fd17da86fcf79... http://www.winehq.org/pipermail/wine-patches/2012-June/115180.html
Am Mittwoch, 20. Juni 2012, 17:52:31 schrieb Daniel Lehman:
Another example: http://www.winehq.org/pipermail/wine-patches/2012-January/110398.html http://source.winehq.org/git/wine.git/commit/b1f04e23bf361e06d239e03693c904a 597b9a32d
I had added a redundant null check in both A and W paths. he simplified it by making just the W path handle the null
-
Alex Henrie -
Dan Kegel -
Daniel Lehman -
Stefan Dösinger