RFC: Use editline in winedbg

[Jeremy White]

Hi folks,

The attached patch dynamically detects and uses the BSD licensed editline
library (a pretty close replacement for readline), if it's available.
This gives winedbg command line recall.

This gets around readline's license requirements.

I'm nervous because I wasn't sure if that was the only issue with readline,
or if there were further issues.  Wack me with a clue bat
if this is wrong, otw, I'll submit it.

Cheers,

Jeremy

[Robert Shearman]

Jeremy White wrote:
> Hi folks,
>
> The attached patch dynamically detects and uses the BSD licensed editline
> library (a pretty close replacement for readline), if it's available.
> This gives winedbg command line recall.

I think this should be available via Win32 calls without the licensing 
issues. See dlls/kernel/editline.c
I'm not sure if winedbg is currently supposed to support it and there is 
a bug, or if it just hasn't enabled the feature, or if it is even able 
to use it.

Rob

[Mike Hearn]

On Sat, 04 Dec 2004 17:17:28 -0600, Robert Shearman wrote:
> I think this should be available via Win32 calls without the licensing 
> issues. See dlls/kernel/editline.c

Yeah, maybe, though I'm not sure how easy it'd be to integrate readline
with that stuff. I *really* *really* want this feature, it'd make my life
approximately 110.4% better, so at the risk of annoying Alexandre
I'll vote +1 for putting it in even if the code is in the wrong place and
UNIX specific. Because I want it that much :)

[Robert Shearman]

Mike Hearn wrote:
> On Sat, 04 Dec 2004 17:17:28 -0600, Robert Shearman wrote:
> > I think this should be available via Win32 calls without the licensing 
> > issues. See dlls/kernel/editline.c
>
> Yeah, maybe, though I'm not sure how easy it'd be to integrate readline
> with that stuff. I *really* *really* want this feature, it'd make my life
> approximately 110.4% better, so at the risk of annoying Alexandre
> I'll vote +1 for putting it in even if the code is in the wrong place and
> UNIX specific. Because I want it that much :)

It *should* be working at the moment, but it isn't for some reason. If 
you *really* *really* want this feature right now, then you can use 
Jeremy's patch, but we should find out why the console functions aren't 
doing what we expect.

Rob

[Jeremy White]

Robert Shearman wrote:
> Jeremy White wrote:
> > Hi folks,
> >
> > The attached patch dynamically detects and uses the BSD licensed editline
> > library (a pretty close replacement for readline), if it's available.
> > This gives winedbg command line recall.
>
> I think this should be available via Win32 calls without the licensing 
> issues. See dlls/kernel/editline.c
> I'm not sure if winedbg is currently supposed to support it and there is 
> a bug, or if it just hasn't enabled the feature, or if it is even able 
> to use it.

Ouch.  Clue bats hurt; I think I've just walked into a tar pit,
haven't I?  Now I seem to recall battles over winedbg and how consoles
work.  Sadly, I can't remember all of the gory details (hence,
the need for the clue bat).

With the attached patch, winedbg --console starts a Win32 style console for
it's session, and indeed, the Win32 console editing stuff works
out just fine.

But I can't resize the window and don't have a scroll bar.

But there is an alternate and/or better way to do this, isn't there?
I set WINECONSOLE or something, right?  More clues would be welcome.

Cheers,

Jeremy

[Andreas Mohr]

Hi,

On Sat, Dec 04, 2004 at 04:54:14PM -0600, Jeremy White wrote:
> Hi folks,
>
> The attached patch dynamically detects and uses the BSD licensed editline
> library (a pretty close replacement for readline), if it's available.
> This gives winedbg command line recall.

Very nice, finally!

Now where's the warning message that says:
"editline library not detected: command line history won't be available..."
? ;-)

Andreas Mohr

[Eric Pouech]

Jeremy White a écrit :
> Hi folks,
>
> The attached patch dynamically detects and uses the BSD licensed editline
> library (a pretty close replacement for readline), if it's available.
> This gives winedbg command line recall.
>
> This gets around readline's license requirements.
>
> I'm nervous because I wasn't sure if that was the only issue with readline,
> or if there were further issues.  Wack me with a clue bat
> if this is wrong, otw, I'll submit it.

there's a full readline support in dlls/kernel32, and there's no reason, I 
repeat NO REASON, to put dedicated readline support in winedbg.
dlls/kernel32 is the only place for readline/editline however you call it.
regarding consoles, there are two things you can do:
1/ run winedbg in a powerful wine console: wineconsole winedbg <bla bla>
2/ add, in dlls/kernel32, support for editline/readline when std in/out are not 
attached to a wine console (which is was 1/ does), but to regular files (you 
have to detect when those files are tty:s and react accordingly to 
ReadFile/WriteFile calls)

A+