Q: Can you give a simple example of such a program (preferably downloadable)? A: Yes. If you have Simplified Chinese environment, you can try: http://update.cz88.net/soft/qqwry.rar which is a freeware for IP address-to-geographical address translation. Before patching WINE, most (though not all) labels and all buttons show garbage code. None after.
Q:Can you add a conformance test showing that your patch is correct? A: I have tried editplus, acdsee, and gvim in en_US and zh_CN.GBK locale/encodings. They all ran well. I also tried the German version of winrar in de locale, no problem either. I don't think we need to prove this patch is correct because it is certainly wrong and introduced a bug. However, `any sufficiently advanced bug becomes a feature'. In the source code of Microsoft Windows NT/2k/XP, or to be excact, in the file "private/windows/shell/accesory/spechars/charmap.c" they confessed there is a bug in GDI that `assumes the font's default charset is always the system default locale'.
I know peeking into The source code is illegal, but I've only done this some 24 hrs after I submitted this patch. So this patch has nothing to do with my undesirable deed.
Xin
On 8/19/07, Dan Kegel dank@kegel.com wrote:
Xin Guan wrote:
This patch solves the problem that many MBCS programs display garbage code for text strings. Because most windows programmers do not handle charsets properly, we have to force DEFAULT_CHARSET in here.
Can you give a simple example of such a program (preferably downloadable)?
Can you add a conformance test showing that your patch is correct?
- Dan
On 8/19/07, Guan Xin guanx.bac@gmail.com wrote:
Q: Can you give a simple example of such a program (preferably downloadable)? A: Yes. If you have Simplified Chinese environment, you can try: http://update.cz88.net/soft/qqwry.rar which is a freeware for IP address-to-geographical address translation. Before patching WINE, most (though not all) labels and all buttons show garbage code. None after.
Q:Can you add a conformance test showing that your patch is correct? A: I have tried editplus, acdsee, and gvim in en_US and zh_CN.GBK locale/encodings. They all ran well. I also tried the German version of winrar in de locale, no problem either. I don't think we need to prove this patch is correct because it is certainly wrong and introduced a bug. However, `any sufficiently advanced bug becomes a feature'. In the source code of Microsoft Windows NT/2k/XP, or to be excact, in the file "private/windows/shell/accesory/spechars/charmap.c" they confessed there is a bug in GDI that `assumes the font's default charset is always the system default locale'.
I know peeking into The source code is illegal, but I've only done this some 24 hrs after I submitted this patch. So this patch has nothing to do with my undesirable deed.
No patches will be accepted from you for the Wine project because you've looked at Windows source code.
I have submitted no patch after looking at Windows source code. The original submission certainly introduced to WINE nothing but a bug. I was later forced to prove this bug is necessary.
On 8/20/07, James Hawkins truiken@gmail.com wrote:
No patches will be accepted from you for the Wine project because you've looked at Windows source code.
-- James Hawkins
On 8/19/07, Guan Xin guanx.bac@gmail.com wrote:
I have submitted no patch after looking at Windows source code. The original submission certainly introduced to WINE nothing but a bug. I was later forced to prove this bug is necessary.
It doesn't matter when you looked at the code versus when you submitted the patch. You prove a 'bug' is necessary by writing test cases. Also, please bottom-post in this mailing list.
-- James Hawkins
On 8/20/07, James Hawkins truiken@gmail.com wrote:
It doesn't matter when you looked at the code versus when you submitted the patch. You prove a 'bug' is necessary by writing test cases. Also, please bottom-post in this mailing list.
-- James Hawkins
Acturally, I have test cases because I found where the problem resides by looking into my own Windows program's source code, which was written some years ago and has garbage code problems with WINE. Does this mail list support attachment? May I post my source code here? And maybe also a binary (.exe).
However, I could only guarantee, say, 99% correctness of this patch. I thought you might want 100% confidence of its correctness when conformance test was demanded (see prev.). This can not be achieved without knowing Microsoft itself is retaining this bug. So I looked at their source code afterwards.
I think I might misunderstood your meaning by "conformance test". If the test need not be thorough or guarantee 100% correctness of the patch, only my own Windows program's source code are needed.
Xin
-
Guan Xin -
James Hawkins