Default GitLab merge request target

[Alex Henrie]

Would it be possible to make merge requests from forked Wine projects
target the upstream Wine project by default, as described at [1]? I
just accidentally created a merge request to merge my own topic branch
into my own master branch, because for some reason that's the default
when you click the "Create merge request" button in the "You pushed to
<topic branch> just now" banner.

-Alex

[1] https://docs.gitlab.com/14.10/ee/user/project/merge_requests/creating_merge_...

[Alex Henrie]

On Mon, May 2, 2022 at 10:19 PM Alex Henrie  wrote:
> Would it be possible to make merge requests from forked Wine projects
> target the upstream Wine project by default, as described at [1]? I
> just accidentally created a merge request to merge my own topic branch
> into my own master branch, because for some reason that's the default
> when you click the "Create merge request" button in the "You pushed to
> <topic branch> just now" banner.
>
> -Alex
>
> [1] https://docs.gitlab.com/14.10/ee/user/project/merge_requests/creating_merge_...

Aha, the merge target default corrected itself as soon as I changed my
fork's visibility from private to public. It's really confusing
because when you go to fork a project, "Visibility level" is shown as
"Public", but once you select your username, it changes to "Private".
I searched for how to disable this visibility-changing "feature" but
found no clear answer. Perhaps we should simply forbid private
projects altogether, which can be done per the instructions at [1].
Because Wine is a public project, I'm not convinced that there is much
value in allowing private forks, and it would prevent contributors
from being stabbed by the confusing interface.

-Alex

[1] https://docs.gitlab.com/14.10/ee/user/admin_area/settings/visibility_and_acc...

[Alexandre Julliard]

Alex Henrie  writes:
> On Mon, May 2, 2022 at 10:19 PM Alex Henrie  wrote:
> > Would it be possible to make merge requests from forked Wine projects
> > target the upstream Wine project by default, as described at [1]? I
> > just accidentally created a merge request to merge my own topic branch
> > into my own master branch, because for some reason that's the default
> > when you click the "Create merge request" button in the "You pushed to
> > <topic branch> just now" banner.
> >
> > -Alex
> >
> > [1] https://docs.gitlab.com/14.10/ee/user/project/merge_requests/creating_merge_...
>
> Aha, the merge target default corrected itself as soon as I changed my
> fork's visibility from private to public. It's really confusing
> because when you go to fork a project, "Visibility level" is shown as
> "Public", but once you select your username, it changes to "Private".
> I searched for how to disable this visibility-changing "feature" but
> found no clear answer. Perhaps we should simply forbid private
> projects altogether, which can be done per the instructions at [1].
> Because Wine is a public project, I'm not convinced that there is much
> value in allowing private forks, and it would prevent contributors
> from being stabbed by the confusing interface.

I've changed this for now, we'll see how it works. Thanks for the
feedback!