Re: [PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.

[Nikolay Sivov]

On 05.04.2017 10:15, Stefan Dösinger wrote:
> dlls/comctl32/tests/msg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h
> index 3fa0fae..b30b5d8 100644
> --- a/dlls/comctl32/tests/msg.h
> +++ b/dlls/comctl32/tests/msg.h
> @@ -369,7 +369,7 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index,
>              context, expected->message, actual->message);
>      }
> - if(todo && !failcount) /* succeeded yet marked todo */
> - if(todo && !failcount && !broken(TRUE)) /* succeeded yet marked todo */
> {
>     dump++;
>     todo_wine

This patch is marked is failed by testbot, but it looks like bot
inability to deal with header file change in tests directory, as it
still tries to run some tests.

Anyway, could you make it look similar to user32/tests/msg.c? It's using:

---
    if( todo && !failcount) /* succeeded yet marked todo */
        todo_wine {
            if (!strcmp(winetest_platform, "wine")) dump++;
---

Platform is tested directly. It's not the only place where it's done
like that, and it's more readable than broken(1), I think.

[PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.

[Stefan Dösinger]

Am 2017-04-05 um 14:36 schrieb Nikolay Sivov:
> This patch is marked is failed by testbot, but it looks like bot
> inability to deal with header file change in tests directory, as it
> still tries to run some tests.

Yeah, I think so, especially since the follow-up patches run ok.
> Anyway, could you make it look similar to user32/tests/msg.c? It's using:
> if( todo && !failcount) /* succeeded yet marked todo */
>     todo_wine {
>         if (!strcmp(winetest_platform, "wine")) dump++;
>
> Platform is tested directly. It's not the only place where it's done
> like that, and it's more readable than broken(1), I think.

Sure, I'll change it :-)

[PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.

[Francois Gouget]

On Wed, 5 Apr 2017, Nikolay Sivov wrote:
[...]
> This patch is marked is failed by testbot, but it looks like bot
> inability to deal with header file change in tests directory, as it
> still tries to run some tests.

Yes, that's bug 31789 which should be fixed now (I'll update Bugzilla 
once that's confirmed).
https://bugs.winehq.org/show_bug.cgi?id=31789

I committed the fix a bit before the patchset but part of the fix 
applies to code that's checked out on the build VM and that is not 
updated automatically :-( So I updated the VM and things would work fine 
after the next 'Update Wine to latest git' job is run.

And I'll update the TestBot so the checkout on the build VM is updated 
automatically.