[PATCH] Fix Block scope compound literal's lifetime issues.

[Martin Liška]

Hi.

I'm sending patch that addresses miscompilation seen with GCC 9.

Martin

[Alexandre Julliard]

Martin Liška  writes:
> Hi.
>
> I'm sending patch that addresses miscompilation seen with GCC 9.
>
> Martin
>
> From 9ef1f211e4adb8855783bcbd93229386c1aeacf1 Mon Sep 17 00:00:00 2001
> From: Martin Liska 
> Date: Mon, 10 Jun 2019 10:57:32 +0200
> Subject: [PATCH] Fix Block scope compound literal's lifetime issues.
>
> Starting from GCC 9, compound liferal's scope has changed:
> https://www.gnu.org/software/gcc/gcc-9/porting_to.html#complit
>
> That's causing multiple issues, where one is analyzed here:
> https://bugzilla.suse.com/show_bug.cgi?id=1137071#c4
>
> I used a script to replace macros with a static const variables:
> https://gist.github.com/marxin/945c7bc01fe375141526284031e85db6

Most places already have the static const fallback, you can use that
instead of adding another one.

[Martin Liška]

On 6/11/19 6:17 PM, Alexandre Julliard wrote:
> Martin Liška  writes:
> > Hi.
> >
> > I'm sending patch that addresses miscompilation seen with GCC 9.
> >
> > Martin
> >
> > From 9ef1f211e4adb8855783bcbd93229386c1aeacf1 Mon Sep 17 00:00:00 2001
> > From: Martin Liska 
> > Date: Mon, 10 Jun 2019 10:57:32 +0200
> > Subject: [PATCH] Fix Block scope compound literal's lifetime issues.
> >
> > Starting from GCC 9, compound liferal's scope has changed:
> > https://www.gnu.org/software/gcc/gcc-9/porting_to.html#complit
> >
> > That's causing multiple issues, where one is analyzed here:
> > https://bugzilla.suse.com/show_bug.cgi?id=1137071#c4
> >
> > I used a script to replace macros with a static const variables:
> > https://gist.github.com/marxin/945c7bc01fe375141526284031e85db6
>
> Most places already have the static const fallback, you can use that
> instead of adding another one.

You are right, I'm sending update version of the patch.

Martin