Re: comctl32/tests: Using unsigned constants to remove sign comparison warning.

[Nikolay Sivov]

On Fri, May 27, 2011 at 5:16 PM, Marko Nikolic  wrote:
> dlls/comctl32/tests/treeview.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c
> index 5fd26a0..b1eb85e 100644
> --- a/dlls/comctl32/tests/treeview.c
> +++ b/dlls/comctl32/tests/treeview.c
> @@ -634,7 +634,7 @@ static void test_get_set_bkcolor(void)
>
> /* If the value is -1, the control is using the system color for the background color. */
>     crColor = (COLORREF)SendMessage( hTree, TVM_GETBKCOLOR, 0, 0 );
> - ok(crColor == -1, "Default background color reported as 0x%.8x\n", crColor);
> - ok(crColor == 0xffffffff, "Default background color reported as 0x%.8x\n", crColor);

~0 looks better here imo.
>

comctl32/tests: Using unsigned constants to remove sign comparison warning.

[David Laight]

On Fri, May 27, 2011 at 10:09:04PM +0400, Nikolay Sivov wrote:
> On Fri, May 27, 2011 at 5:16 PM, Marko Nikolic  wrote:
> > ?dlls/comctl32/tests/treeview.c | ? ?6 +++---
> > ?1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c
> > index 5fd26a0..b1eb85e 100644
> > --- a/dlls/comctl32/tests/treeview.c
> > +++ b/dlls/comctl32/tests/treeview.c
> > @@ -634,7 +634,7 @@ static void test_get_set_bkcolor(void)
> >
> > ? ? /* If the value is -1, the control is using the system color for the background color. */
> > ? ? crColor = (COLORREF)SendMessage( hTree, TVM_GETBKCOLOR, 0, 0 );
> > - ? ?ok(crColor == -1, "Default background color reported as 0x%.8x\n", crColor);
> > - ? ?ok(crColor == 0xffffffff, "Default background color reported as 0x%.8x\n", crColor);
>
> ~0 looks better here imo.

Rather ~0u
The 0xffffffff should be 0xffffffffu

David

comctl32/tests: Using unsigned constants to remove sign comparison warning.

[Marko Nikolic]

David Laight wrote:
> On Fri, May 27, 2011 at 10:09:04PM +0400, Nikolay Sivov wrote:
> > On Fri, May 27, 2011 at 5:16 PM, Marko Nikolic  wrote:
> > > ?dlls/comctl32/tests/treeview.c | ? ?6 +++---
> > > ?1 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/dlls/comctl32/tests/treeview.c
> > > b/dlls/comctl32/tests/treeview.c index 5fd26a0..b1eb85e 100644
> > > --- a/dlls/comctl32/tests/treeview.c
> > > +++ b/dlls/comctl32/tests/treeview.c
> > > @@ -634,7 +634,7 @@ static void test_get_set_bkcolor(void)
> > >
> > > ? ? /* If the value is -1, the control is using the system color for
> > > the background color. */ ? ? crColor = (COLORREF)SendMessage( hTree,
> > > TVM_GETBKCOLOR, 0, 0 ); - ? ?ok(crColor == -1, "Default background
> > > color reported as 0x%.8x\n", crColor); + ? ?ok(crColor == 0xffffffff,
> > > "Default background color reported as 0x%.8x\n", crColor);
> >
> > ~0 looks better here imo.
>
> Rather ~0u
> The 0xffffffff should be 0xffffffffu
>
> David

You are right, thanks, I'll update the patch.

Marko