Re: enhmetafile: Create little-endian EMF files on big-endian machines (fixed)

[Phil Krylov]

Hi,

On Tue, 11 Apr 2006 20:03:22 +0400
Phil Krylov  wrote:
> This patch fixes the generation of EMF files (which are little-endian by nature)
> on big-endian machines. It is by no means complete - some record types are still
> unsupported, and reading of little-endian EMFs on big-endian machines still does
> not work - but it works for my app and can be used as a base for future
> improvements.

Anything wrong with this patch? Should I try to improve it in the direction of
supporting more metafile record types and supporting reading little-endian EMFs
from disk? Or change everything at all?

The subject was recently discussed in this thread:
http://www.winehq.org/pipermail/wine-devel/2006-April/046606.html

-- Ph.

enhmetafile: Create little-endian EMF files on big-endian machines (fixed)

[Alexandre Julliard]

Phil Krylov  writes:
> Anything wrong with this patch? Should I try to improve it in the direction of
> supporting more metafile record types and supporting reading little-endian EMFs
> from disk? Or change everything at all?

I think the direction is OK, but the macros are fairly ugly, and
non-portable. I'd suggest doing the conversion with inline functions
instead.

enhmetafile: Create little-endian EMF files on big-endian machines (fixed)

[Phil Krylov]

On Wed, 19 Apr 2006 12:52:35 +0200
Alexandre Julliard  wrote:
> Phil Krylov  writes:
> > Anything wrong with this patch? Should I try to improve it in the direction of
> > supporting more metafile record types and supporting reading little-endian EMFs
> > from disk? Or change everything at all?
>
> I think the direction is OK, but the macros are fairly ugly, and
> non-portable. I'd suggest doing the conversion with inline functions
> instead.

Posted an updated version to wine-patches.

-- Ph.