Re: (resend)[3/6]dwrite: Implement GetInformationalStrings

[Alexandre Julliard]

Aric Stewart  writes:
> @@ -53,6 +54,8 @@ struct dwrite_font_data {
>      DWRITE_FONT_SIMULATIONS simulations;
>      DWRITE_FONT_METRICS metrics;
> - IDWriteLocalizedStrings *info_strings[23];

Where does this 23 come from?

(resend)[3/6]dwrite: Implement GetInformationalStrings

[Aric Stewart]

On Fri Sep  5 08:36:39 2014, Alexandre Julliard wrote:
> Aric Stewart  writes:
> > @@ -53,6 +54,8 @@ struct dwrite_font_data {
> >       DWRITE_FONT_SIMULATIONS simulations;
> >       DWRITE_FONT_METRICS metrics;
> > - IDWriteLocalizedStrings *info_strings[23];
>
> Where does this 23 come from?

http://www.microsoft.com/typography/otspec/name.htm

Name IDs 0-22 are the predefined name ids.

The correlate to DWRITE_INFORMATIONAL_STRING_ID values
-aric

(resend)[3/6]dwrite: Implement GetInformationalStrings

[Alexandre Julliard]

Aric Stewart  writes:
> http://www.microsoft.com/typography/otspec/name.htm
>
> Name IDs 0-22 are the predefined name ids.
>
> The correlate to DWRITE_INFORMATIONAL_STRING_ID values

I don't see much correlation in the values...

(resend)[3/6]dwrite: Implement GetInformationalStrings

[Aric Stewart]

On Fri Sep  5 08:53:32 2014, Alexandre Julliard wrote:
> Aric Stewart  writes:
> > http://www.microsoft.com/typography/otspec/name.htm
> >
> > Name IDs 0-22 are the predefined name ids.
> >
> > The correlate to DWRITE_INFORMATIONAL_STRING_ID values
>
> I don't see much correlation in the values...

Well, that is embarrassing.  I should have double checked, You are 
correct. The enum does not correspond to the opentype indexes. Seeing 
that they where in the same order was not enough.

I will rework that patch to be correct.

Thanks,
-aric