-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Fyi, I asked for these tests to be added to demonstrate that rejecting trailing backslashes is the behavior of reg.exe and not the advapi32 functions.
Patch 1 and 2 look good to me, and I made Jonathan aware of the unchecked ret assign in patch 3 on IRC.
Am 2014-11-06 19:03, schrieb Jonathan Vollebregt:
dlls/advapi32/tests/registry.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 382d8cc..3aff541 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -953,6 +953,11 @@ static void test_reg_open_key(void) ok(hkResult != NULL, "hkResult != NULL\n"); RegCloseKey(hkResult);
- /* trailing slashes */
- ret = RegOpenKeyA(HKEY_CURRENT_USER, "Software\Wine\Test\\", &hkResult);
- ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret);
- RegCloseKey(hkResult);
- /* open nonexistent key
*/
- check that hkResult is set to NULL
@@ -1218,6 +1223,12 @@ static void test_reg_create_key(void) RegCloseKey(hkey1); }
- /* trailing backslash characters */
- ret = RegCreateKeyExA(hkey_main, "Subkey4\\", 0, NULL, 0, KEY_NOTIFY, NULL, &hkey1, NULL);
- ok(ret == ERROR_SUCCESS, "RegCreateKeyExA failed with error %d\n", ret);
- RegDeleteKeyA(hkey1, "");
- RegCloseKey(hkey1);
- /* WOW64 flags - open an existing key */ hkey1 = NULL; ret = RegCreateKeyExA(HKEY_LOCAL_MACHINE, "Software", 0, NULL, 0, KEY_READ|KEY_WOW64_32KEY, NULL, &hkey1, NULL);
-
Stefan Dösinger