This patch fails; see http://source.winehq.org/patches/ and http://source.winehq.org/patches/data/79288.testfail
Got a lot of errors on NT4, and 1 on other systems batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@'
You might want to use @todo_wine@ as documented on http://wiki.winehq.org/CmdConformanceTests
Patches generating at least 1 error on one of testbot's systems (NT included) have 0% chance of being committed (see http://wiki.winehq.org/SubmittingPatches) [I know NT4 is sometimes $#!+... be thankful win9x is not a prerequisite anymore... ;) ]
Frédéric
PS: "resend" is used for unchanged patches (or only rebased); in other cases you should use "try N"
2011/9/25 Frédéric Delanoy frederic.delanoy@gmail.com:
This patch fails; see http://source.winehq.org/patches/ and http://source.winehq.org/patches/data/79288.testfail
Got a lot of errors on NT4, and 1 on other systems batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@'
You might want to use @todo_wine@ as documented on http://wiki.winehq.org/CmdConformanceTests
Patches generating at least 1 error on one of testbot's systems (NT included) have 0% chance of being committed (see http://wiki.winehq.org/SubmittingPatches) [I know NT4 is sometimes $#!+... be thankful win9x is not a prerequisite anymore... ;) ]
Frédéric
PS: "resend" is used for unchanged patches (or only rebased); in other cases you should use "try N"
+echo @echo 0 > "say.bat" You should probably use .cmd extension instead of .bat. There're sometimes issues with .bat, especially on NT which switches on Win9x/DOS compatibility mode IIRC (or some other weirdness)
Also, as Dan suggested, you should probably send smaller patches / series. This way they can be more easily reviewed and have a better chance to be committed by Alexandre (provided all tests pass of course)
Frédéric
-
Frédéric Delanoy