wouldn't it be nice to have winemaker-generated sources automatically add "-fshort-wchar" to the C compiler options?
To make this robust, one could write a configure test for it. Martin
On December 11, 2002 08:13 am, Martin Wilck wrote:
wouldn't it be nice to have winemaker-generated sources automatically add "-fshort-wchar" to the C compiler options?
I personally don't understand why we even bother with other options. The -fshort-wchar is the only correct fix to the problem, and just by enumerating the other hacks we just confuse the issue.
Who is crazy enough to use the other hacks where there is such a simple (and correct) fix available? This option is probably supported nowadays by most gcc installations, and for the 1 in 1000 that doesn't want to use it (for whatever reason), they will bring it up on wine-devel and they'll get an answer. No point in cluttering the documentation (Winelib User's Guide), the scripts (winemaker), etc. with them.
Am Mit, 2002-12-11 um 16.17 schrieb Dimitrie O. Paun:
The -fshort-wchar is the only correct fix to the problem, and just by enumerating the other hacks we just confuse the issue.
Agreed - at least I see no need for automating them.
Who is crazy enough to use the other hacks where there is such a simple (and correct) fix available? This option is probably supported nowadays by most gcc installations, and for the 1 in 1000 that doesn't want to use it (for whatever reason), they will bring it up on wine-devel and they'll get an answer. No point in cluttering the documentation (Winelib User's Guide), the scripts (winemaker), etc. with them.
well the configure script should probably check if -fshort-wchar is supported, add the option to CFLAGS if yes, and issue a warning if no.
Martin
On December 11, 2002 10:52 am, Martin Wilck wrote:
well the configure script should probably check if -fshort-wchar is supported, add the option to CFLAGS if yes, and issue a warning if no.
But the problem is that winemaker will run on different systems that configure runs on... It will get it mostly right, but now always. However, my comment was referring to this bit: http://www.winehq.org/Docs/winelib-user/unicode.shtml It makes things look complicated. It should be: "Use a gcc that support -fshort-wchar (2.9.7 or later)"
Instead, we present 3 options as if they are *equally* likely/desirable, and then we let the poor developer not familiar with the problem to agonize over which option to use. In reality, 1. is likely used in 99.999% of case, the others are clever hacks that are maybe interesting for historical reasons nowadays.
I think we should try to make the documentation concise, not long. Most people think that the quality of documentation is measured in pages. Often times, is inversely proportional. Let's try to document a preferred way of doing things (maybe present some options when they are equally likely).
That being said, I want to stress that this is a minor nit, and that I actually like our documentation (incomplete as it is). I just picked it up as an excuse for my daily rant... :)
Am Mit, 2002-12-11 um 16.49 schrieb Dimitrie O. Paun:
On December 11, 2002 10:52 am, Martin Wilck wrote:
well the configure script should probably check if -fshort-wchar is supported, add the option to CFLAGS if yes, and issue a warning if no.
But the problem is that winemaker will run on different systems that configure runs on... It will get it mostly right, but now always.
I can't follow you. Winemaker generates a configure.ac file. You need to run autoconf and configure anyway to build your code. We just need to make sure that Winemaker puts a test for -fshort-wchar into configure.ac.
What am I missing?
Martin
On December 11, 2002 12:05 pm, Martin Wilck wrote:
I can't follow you. Winemaker generates a configure.ac file. You need to run autoconf and configure anyway to build your code. We just need to make sure that Winemaker puts a test for -fshort-wchar into configure.ac.
What am I missing?
Nothing. I forgot that winemaker generates a configure.ac file as well. :) So yeah, a test in there would be good, if it fails we should report an error. If someone really needs to use the other hacks, they can just edit the configure.ac to take the test out.
-
Dimitrie O. Paun -
Martin Wilck