Re: [v2 PATCH] inetcomm: Implement IMimeBody GetPropInfo

[Alexandre Julliard]

Alistair Leslie-Hughes  writes:
> - memset(&info, 0, sizeof(info));
> - hr = IMimeBody_GetPropInfo(body, "Subject", &info);
> - ok(hr == S_OK, "ret %08x\n", hr);
> - if(hr == S_OK)
> - {
> -
>   ok(info.dwMask == 0, "Invalid mask 0x%08x\n", info.dwFlags);
> -
>   ok(info.dwFlags == 0, "Invalid flags 0x%08x\n", info.dwFlags);
> -
>   ok(info.ietEncoding == 0, "Invalid encoding %d\n", info.ietEncoding);
> -
>   ok(info.dwPropId == 0, "Invalid propid %d\n", info.dwPropId);
> - }
> -
> - memset(&info, 0, sizeof(info));
> - info.dwPropId = 1024;
> - info.ietEncoding = 99;
> - hr = IMimeBody_GetPropInfo(body, "Subject", &info);
> - ok(hr == S_OK, "ret %08x\n", hr);
> - if(hr == S_OK)
> - {
> -
>   ok(info.dwMask == 0, "Invalid mask 0x%08x\n", info.dwFlags);
> -
>   ok(info.dwFlags == 0, "Invalid flags 0x%08x\n", info.dwFlags);
> -
>   ok(info.ietEncoding == 99, "Invalid encoding %d\n", info.ietEncoding);
> -
>   ok(info.dwPropId == 1024, "Invalid propid %d\n", info.dwPropId);
> - }

I still think it would be better to memset with a non-zero value so you
can reliably see what has been set.