Re: [PATCH] dwrite: Fix typos, and fix definition of Mac LangCodes for Welsh and up.

[Nikolay Sivov]

On 12.02.2016 12:00, Charles Davis wrote:
> Signed-off-by: Charles Davis
>
> dlls/dwrite/opentype.c | 39 ++++++++++++++++++++++++++++++++++++---
>  1 file changed, 36 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c
> index 5b29c21..7d59bf8 100644
> --- a/dlls/dwrite/opentype.c
> +++ b/dlls/dwrite/opentype.c
> @@ -470,7 +470,7 @@ enum TT_NAME_MAC_LANGUAGE_ID
>      TT_NAME_MAC_LANGID_LAO,
>      TT_NAME_MAC_LANGID_VIETNAMESE,
>      TT_NAME_MAC_LANGID_INDONESIAN,
> - TT_NAME_MAC_LANGID_TAGALONG,
> - TT_NAME_MAC_LANGID_TAGALOG,
> TT_NAME_MAC_LANGID_MALAY_ROMAN,
> TT_NAME_MAC_LANGID_MALAY_ARABIC,
> TT_NAME_MAC_LANGID_AMHARIC,
>
> @@ -483,11 +483,11 @@ enum TT_NAME_MAC_LANGUAGE_ID
>      TT_NAME_MAC_LANGID_NYANJA,
>      TT_NAME_MAC_LANGID_MALAGASY,
>      TT_NAME_MAC_LANGID_ESPERANTO,
> - TT_NAME_MAC_LANGID_WELSH,
> - TT_NAME_MAC_LANGID_WELSH = 128,
> TT_NAME_MAC_LANGID_BASQUE,
> TT_NAME_MAC_LANGID_CATALAN,
> TT_NAME_MAC_LANGID_LATIN,
> - TT_NAME_MAC_LANGID_QUENCHUA,
> - TT_NAME_MAC_LANGID_QUECHUA,
> TT_NAME_MAC_LANGID_GUARANI,
> TT_NAME_MAC_LANGID_AYMARA,
> TT_NAME_MAC_LANGID_TATAR,

Hi,

typos come from https://www.microsoft.com/typography/otspec/name.htm,
thanks for fixing this. Broken indexing is something I missed though.
I'm curious how did you spot this? Is there some fonts around that use
id >= 128 on mac?

[PATCH] dwrite: Fix typos, and fix definition of Mac LangCodes for Welsh and up.

[Charles Davis]

On Fri, Feb 12, 2016 at 4:14 AM, Nikolay Sivov  wrote:
> Hi,
>
> typos come from https://www.microsoft.com/typography/otspec/name.htm,
> thanks for fixing this. Broken indexing is something I missed though.
> I'm curious how did you spot this?

I read Apple's headers.

Chip

​P.S. I must apologize if this comes out as HTML mail. Mail.app is horribly
broken right now on Mac OS, so I'm using Gmail's web client until I can set
up a better client.​