Re: msi: Fix use of uninitialized variable (Coverity)

[Paul Vriens]

Andrew Talbot wrote:
> This patch should fix Coverity bug CID-562. Additionally, I have pinpointed
> another suspected use-before-initialization bug, for future consideration.
> -- Andy.
>
> Changelog:
>     msi: Fix use of uninitialized variable (Coverity).

Wouldn't it be easier to set env to NULL when declaring it and do a:

if (env) RegCloseKey(env);

Cheers,

Paul.

msi: Fix use of uninitialized variable (Coverity)

[Andrew Talbot]

Paul Vriens wrote:
> Wouldn't it be easier to set env to NULL when declaring it and do a:
>
> if (env) RegCloseKey(env);
>
> Cheers,
>
> Paul.

Indeed it would! I shall submit a vastly simplified retry, accordingly. :)