Re: [PATCH 4/6] CMD.EXE: Convert cmd into unicode

[Detlef Riekenberg]

On Di, 2007-05-08 at 00:11 +0100, Jason Edmeades wrote:
> Apologies for the size of this patch - I tried 3 or 4 ways of converting
> chunks to unicode and always ended up duplicating huge bits of code and
> having problems keeping track of duplicated variables that in the end I
> did the lot in one go.

You need TCHAR and friends to reduce the Patch-Size
(char => TCHAR when you did char => WCHAR)

And do not forget "* sizeof(TCHAR)" when calculating the required size
for allocations (HeapAlloc)

[PATCH 4/6] CMD.EXE: Convert cmd into unicode

[Ann & Jason Edmeades]

> > Apologies for the size of this patch - I tried 3 or 4 ways of converting
> > chunks to unicode and always ended up duplicating huge bits of code and
> > having problems keeping track of duplicated variables that in the end I
> > did the lot in one go.
> You need TCHAR and friends to reduce the Patch-Size
> (char => TCHAR when you did char => WCHAR)

Alexandre explicitly stated he didn't want TCHAR's anywhere, hence the
conversion to WCHAR (See post on 5/4/2007, 8:31 re regedit)

Jason