Thanks for your feedback Henri.
By looking at similar cards in the code I found the GT/GTS description were often omitted from mobile (M) cards. I wanted to keep the same text formatting. This is indeed the GT version and I can add that to the patch.
I will sign off the next patch, still getting to grips with git.
--
Date: Mon, 18 Apr 2016 19:00:33 +0200 From: Henri Verbeethverbeet@gmail.com To: wine-develwine-devel@winehq.org Cc: Kim Malmokimmalmo@protonmail.ch Subject: Re: [PATCH] Added Nvidia GT 9700M Message-ID: CAOsNvwyqyR1swwYaPUhiOpu7+TtBRuC9yg33Zi4+KYE1J0EyEw@mail.gmail.com Content-Type: text/plain; charset=UTF-8
On 18 April 2016 at 18:39, Kim Malmoberencamlost@msn.com wrote:
From: Kim Malmokimmalmo@protonmail.ch
dlls/wined3d/directx.c | 2 ++ dlls/wined3d/wined3d_private.h | 1 + 2 files changed, 3 insertions(+)
You're missing the Signed-off-by line. Passing -s to format-patch will add it.
- {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9700M, "NVIDIA GeForce 9700M", DRIVER_NVIDIA_GEFORCE8, 512 },
Is that the correct description string for the card? I'm only finding references to the 9700M GT and 9700M GTS.
On 19 April 2016 at 13:53, Kim Malmo berencamlost@msn.com wrote:
By looking at similar cards in the code I found the GT/GTS description were often omitted from mobile (M) cards. I wanted to keep the same text formatting. This is indeed the GT version and I can add that to the patch.
The only similar cards I see are the "8600M GT" and the "9400M". The 8600M has the suffix, the 9400M looks like it may indeed be broken. More recent cards like e.g. the 8x0M/8x5M series seem to just use a different convention. Unfortunately NVIDIA's naming scheme isn't all that easy to follow. That's of course not limited to NVIDIA, AMD marketing names are a similar mess.
You are correct.
I've cleaned up the patch using your suggested formatting. I also did some extra digging and added the corresponding Mesa driver.
Den 19. april 2016 14:51, skrev Henri Verbeet:
On 19 April 2016 at 13:53, Kim Malmo berencamlost@msn.com wrote:
By looking at similar cards in the code I found the GT/GTS description were often omitted from mobile (M) cards. I wanted to keep the same text formatting. This is indeed the GT version and I can add that to the patch.
The only similar cards I see are the "8600M GT" and the "9400M". The 8600M has the suffix, the 9400M looks like it may indeed be broken. More recent cards like e.g. the 8x0M/8x5M series seem to just use a different convention. Unfortunately NVIDIA's naming scheme isn't all that easy to follow. That's of course not limited to NVIDIA, AMD marketing names are a similar mess.
-
Henri Verbeet -
Kim Malmo