Re: stdarg.h in winbase.h

[Alexandre Julliard]

"Dimitrie O. Paun"  writes:
> With this patch, we can get rid of the stdarg.h
> include from winbase.h if it weren't for the
> FormatMessage() functions:
>
> DWORD       WINAPI FormatMessageA(DWORD,LPCVOID,DWORD,DWORD,LPSTR,DWORD,va_list*);
> DWORD       WINAPI FormatMessageW(DWORD,LPCVOID,DWORD,DWORD,LPWSTR,DWORD,va_list*);
>
> Alexandre, how do we handle this one?

We have to include stdarg.h everywhere we include winbase.h, about 650
files at last count. That's why we need some kind of script...

stdarg.h in winbase.h

[Dimitrie O. Paun]

On Wed, 3 Sep 2003, Alexandre Julliard wrote:
> We have to include stdarg.h everywhere we include winbase.h, about 650
> files at last count. That's why we need some kind of script...

So, in other words, in Windows, the following program does not compile?

#include <winbase.h>

int main() { return 0; }

stdarg.h in winbase.h

[Alexandre Julliard]

"Dimitrie O. Paun"  writes:
> So, in other words, in Windows, the following program does not compile?
>
> #include <winbase.h>
>
> int main() { return 0; }

No it doesn't, and not only because of stdarg.h, our winbase.h also
includes basetsd.h and windef.h that should be removed too. And
similar fixes should be done to all the other headers.

What we really need is first a tool to compare dependencies between
Windows and Wine headers (it should be trivial to hack makedep.c to do
this), and then another tool to fix C files intelligently (i.e.
without adding too many duplicated includes).

stdarg.h in winbase.h

[Francois Gouget]

On Wed, 3 Sep 2003, Dimitrie O. Paun wrote:
[...]
> So, in other words, in Windows, the following program does not compile?
>
> #include <winbase.h>
>
> int main() { return 0; }

Yep. In Windows you always have to do:

#include <windows.h>
int main() { return 0; }

And windows.h includes stdarg.h and winbase.h for you.

stdarg.h in winbase.h

[Eric Pouech]

Alexandre Julliard wrote:
> "Dimitrie O. Paun"  writes:
> > With this patch, we can get rid of the stdarg.h
> > include from winbase.h if it weren't for the
> > FormatMessage() functions:
> >
> > DWORD       WINAPI FormatMessageA(DWORD,LPCVOID,DWORD,DWORD,LPSTR,DWORD,va_list*);
> > DWORD       WINAPI FormatMessageW(DWORD,LPCVOID,DWORD,DWORD,LPWSTR,DWORD,va_list*);
> >
> > Alexandre, how do we handle this one?
>
> We have to include stdarg.h everywhere we include winbase.h, about 650
> files at last count. That's why we need some kind of script...

if someone wants to work on this, here's a little comparison of wine's 
headers (on left hand side) and windows (on the right hand side).
I only listed the headers I add on both sides.

it's rather easy to derive from it the list of the things we include in 
our header when we shouldn't.

as the modification on .c files would be minimal (between doing only 
winbase.h compared to do the rest...), it might be better to do it at 
once (we might end up including stdarg, windef and winbase in most of 
our compilation units)

Notes: I dropped windows.h in the comparison, and I didn't have any 
directX SDK at hand to make the comparison with this part of the 
"platform SDK". I also removed all the header inclusion related to packing

A+

stdarg.h in winbase.h

[Dimitrie O. Paun]

On Wed, 3 Sep 2003, Eric Pouech wrote:
> if someone wants to work on this, here's a little comparison of wine's 
> headers (on left hand side) and windows (on the right hand side).
> I only listed the headers I add on both sides.

Cool -- I'll fix commctrl.h.

stdarg.h in winbase.h

[Eric Pouech]

Dimitrie O. Paun wrote:
> On Wed, 3 Sep 2003, Eric Pouech wrote:
> > if someone wants to work on this, here's a little comparison of wine's 
> > headers (on left hand side) and windows (on the right hand side).
> > I only listed the headers I add on both sides.
>
> Cool -- I'll fix commctrl.h.

I have already started the winmm part, so no need to look at it.
(sending to wine-patches tonight when I'm back home, likely)

A+