Thanks.
I attached what I believe to be improved version, while keeping your positioning logic. It fixes compiler warning, loading custom button text from resources, naming issues, and minor formatting inconsistencies.
If you're okay with it, I'll submit under your name, or you can do it yourself.
Nikolay
Many thanks for looking into it, looks a lot better now.
I just noticed another issue in my code though. The line
int new_alignment = desc->dialog_width - (DIALOG_SPACING + line_widths[i]);
has to be
int new_alignment = desc->dialog_width - line_widths[i];
After all, we've already calculated DIALOG_SPACING for the right side into the width of the line, so we shouldn't subtract it again.
This fixes the left alignment, without the change it doesn't respect dialog spacing to the left. If you don't object that change, feel free to submit it.
Just a small question, what compiler warning did my original code produce? I didn't get one, and maybe I need to change my setup.
Regards, Fabian Maurer
On 11.06.2017 21:38, Fabian Maurer wrote:
Many thanks for looking into it, looks a lot better now.
I just noticed another issue in my code though. The line
int new_alignment = desc->dialog_width - (DIALOG_SPACING + line_widths[i]);
has to be
int new_alignment = desc->dialog_width - line_widths[i];
After all, we've already calculated DIALOG_SPACING for the right side into the width of the line, so we shouldn't subtract it again.
This fixes the left alignment, without the change it doesn't respect dialog spacing to the left. If you don't object that change, feel free to submit it.
Make sense I guess, applied and sent.
Just a small question, what compiler warning did my original code produce? I didn't get one, and maybe I need to change my setup.
I think it was about uninitialized 'last_button', that's with gcc 6.3.0.
Regards, Fabian Maurer
-
Fabian Maurer -
Nikolay Sivov -
Nikolay Sivov