Signed-off-by: Ziqing Hui zhui@codeweavers.com --- dlls/d3dx10_43/d3dx10_43_main.c | 21 ++++++++++++++++++++- dlls/d3dx10_43/tests/d3dx10.c | 2 -- 2 files changed, 20 insertions(+), 3 deletions(-)
On Thu, Aug 6, 2020 at 4:12 AM Ziqing Hui zhui@codeweavers.com wrote:
Signed-off-by: Ziqing Hui zhui@codeweavers.com
dlls/d3dx10_43/d3dx10_43_main.c | 21 ++++++++++++++++++++- dlls/d3dx10_43/tests/d3dx10.c | 2 -- 2 files changed, 20 insertions(+), 3 deletions(-)
static const DXGI_FORMAT convert_dds_format[] = { DXGI_FORMAT_UNKNOWN, DXGI_FORMAT_R8_UNORM, DXGI_FORMAT_R8G8_UNORM, DXGI_FORMAT_B4G4R4A4_UNORM, DXGI_FORMAT_B5G5R5A1_UNORM, DXGI_FORMAT_B5G6R5_UNORM, DXGI_FORMAT_B8G8R8X8_UNORM, DXGI_FORMAT_B8G8R8A8_UNORM };
Please don't do that, just put each entry on a separate line. Also I'm not entirely happy with the array name, although I don't have any good suggestions for alternatives.
On 8/10/20 11:51 PM, Matteo Bruni wrote:
On Thu, Aug 6, 2020 at 4:12 AM Ziqing Hui zhui@codeweavers.com wrote:
Signed-off-by: Ziqing Hui zhui@codeweavers.com
dlls/d3dx10_43/d3dx10_43_main.c | 21 ++++++++++++++++++++- dlls/d3dx10_43/tests/d3dx10.c | 2 -- 2 files changed, 20 insertions(+), 3 deletions(-)
static const DXGI_FORMAT convert_dds_format[] = { DXGI_FORMAT_UNKNOWN, DXGI_FORMAT_R8_UNORM, DXGI_FORMAT_R8G8_UNORM, DXGI_FORMAT_B4G4R4A4_UNORM, DXGI_FORMAT_B5G5R5A1_UNORM, DXGI_FORMAT_B5G6R5_UNORM, DXGI_FORMAT_B8G8R8X8_UNORM, DXGI_FORMAT_B8G8R8A8_UNORM };
Please don't do that, just put each entry on a separate line. Also I'm not entirely happy with the array name, although I don't have any good suggestions for alternatives.
What about "to_be_converted_format" ?