Re: [PATCH] Version info for comctl32.dll

[gerard patel]

At 08:54 PM 15/03/2001 -0500, you wrote:
<snip>
> for its version info and gets the builtin.  The ver trace looks a little
> strange to me - maybe it will make sense to you?

Do you mean a strangeness that could go away with the following patch :

--- info.c.orig Fri Feb 23 21:37:15 2001
+++ info.c      Fri Mar 16 10:14:19 2001
@@ -503,8 +503,15 @@
          && !VersionInfoIs16( data ) )
     {
         /* convert resource from PE format to NE format */
-        ConvertVersionInfo32To16( (VS_VERSION_INFO_STRUCT32 *)data,
-                                  (VS_VERSION_INFO_STRUCT16 *)data );
+        BYTE *ptemp = HeapAlloc(GetProcessHeap(), 0, datasize);
+        if (ptemp)
+        {
+            ConvertVersionInfo32To16( (VS_VERSION_INFO_STRUCT32 *)data,
+                                  (VS_VERSION_INFO_STRUCT16 *)ptemp );
+            memcpy(data, ptemp, datasize);
+            HeapFree(GetProcessHeap(), 0, ptemp);
+
+        }
     }

return TRUE;

I don't think this will fix your problem, though.

Gerard

[PATCH] Version info for comctl32.dll

On Fri, 16 Mar 2001, gerard patel wrote:
> At 08:54 PM 15/03/2001 -0500, you wrote:
>
> <snip>
> >for its version info and gets the builtin.  The ver trace looks a little
> >strange to me - maybe it will make sense to you?
>
> Do you mean a strangeness that could go away with the following patch :
>
> --- info.c.orig Fri Feb 23 21:37:15 2001
> +++ info.c      Fri Mar 16 10:14:19 2001

I guess so.  I don't see any more of it.

On a related note, I provoked that crash in menu.c again, this time by
hitting an accelerator key (?) for a button that was not enabled at the
time.  Alt-b IIRC.  Here is the last 1400 lines of
+menu,+accel,+msg,+message, with backtrace, regs, and lpinfo.  I
misspelled info local - I was working the debugger blind.  If you don't
want to look at it, just throw it away, I guess.  I can make another any
time.  Or any combination of traces you like, except +relay,+snoop,
which usually crashes by itself.  Maybe I will even fix my debugger
entries.

Lawson