Maarten wrote:
An example is IsWindowUnicode. It always returns TRUE on XP, but it won't do that on 9x. That would mean something like: ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?");
Maybe you can do something like if (CreateWindowExW doesn't work) { /* win95 without MSLU */ ok(!IsWindowUnicode()); } else { /* win95 with MSLU, or something with native unicode support */ ok(IsWindowUnicode()); }
Dmitry wrote:
An example is IsWindowUnicode. It always returns TRUE on XP,
That's not true.
The test you submitted that checks this, http://www.winehq.org/pipermail/wine-patches/2005-July/018839.html must have passed once on Windows, but it seems to be failing now; see e.g. http://test.winehq.org/data/200802131000/xp_rs-winxp-sp2/user32:win.txt which is full of lines like win.c:3656: Test failed: IsWindowUnicode expected to return FALSE
Do you have a Windows system where that test passes currently? - Dan
"Dan Kegel" dank@kegel.com wrote:
The test you submitted that checks this, http://www.winehq.org/pipermail/wine-patches/2005-July/018839.html must have passed once on Windows, but it seems to be failing now; see e.g. http://test.winehq.org/data/200802131000/xp_rs-winxp-sp2/user32:win.txt which is full of lines like win.c:3656: Test failed: IsWindowUnicode expected to return FALSE
Do you have a Windows system where that test passes currently?
Hmm, thanks for pointing this out. The test doesn't pass anymore for me under an up to date XP, and I don't have other systems to test with at the moment.
Looks like at some point DefWindowProcA/W treatment in XP has changed after the introduction of IsWindowUnicode test (at that time the test passed), even a trick we use in class.c with GetProcAddress("DefWindowProcA") doesn't help anymore.
I sent a fix to wine-patches.
"Dan Kegel" dank@kegel.com wrote:
The test you submitted that checks this, http://www.winehq.org/pipermail/wine-patches/2005-July/018839.html must have passed once on Windows, but it seems to be failing now; see e.g. http://test.winehq.org/data/200802131000/xp_rs-winxp-sp2/user32:win.txt which is full of lines like win.c:3656: Test failed: IsWindowUnicode expected to return FALSE
Do you have a Windows system where that test passes currently?
I've performed a little investigation trying to find out at which point XP has changed its behaviour. It's pretty much hard taking into account how many broken user32:win.c tests we have at test.winehq.org (all the tests marked as 'failed' are useless). It looks like the change/breakage occured somewhere at the end of October 2007 - beginning of November 2007:
http://test.winehq.org/data/200710271000/xp_brainless-20071027/user32:win.tx... http://test.winehq.org/data/200710271000/xp_mbv-.48/user32:win.txt
don't have failing IsWindowUnicode tests, but http://test.winehq.org/data/200711072209/#XP suite already has them:
http://test.winehq.org/data/200711072209/xp_200711SCHOEMB/user32:win.txt
-
Dan Kegel -
Dmitry Timoshkov