Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup

[Nikolay Sivov]

Vladimir Pankratov wrote:
> Hello all.
>
> Fixed Lingvo 9.0 crashes on startup.
>
> Changed files:
>
> comctl32/toolbar.c
>
> Thanks.

Maybe it's better to simplify:

+        idealWrap = (infoPtr->nNumButtons - hidden + (rows-1)) / ((rows == 0) ? (rows + 1) : rows);
---
to something like that
---
+        idealWrap = (infoPtr->nNumButtons - hidden + (rows-1)) / (rows ? rows : 1);

comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup

[Vladimir Pankratov]

Nikolay Sivov wrote:
> Vladimir Pankratov wrote:
> > Hello all.
> >
> > Fixed Lingvo 9.0 crashes on startup.
> >
> > Changed files:
> >
> > comctl32/toolbar.c
> >
> > Thanks.
>
> Maybe it's better to simplify:
> -
>    idealWrap = (infoPtr->nNumButtons - hidden + (rows-1)) / ((rows == 0) ? (rows + 1) : rows);
> to something like that
> -
>    idealWrap = (infoPtr->nNumButtons - hidden + (rows-1)) / (rows ? rows : 1);

As I read, the minimum of rows is one, then I wrote:
> - if(rows <= 0) rows = 1;
> -