Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W} (RESEND)

[Dmitry Timoshkov]

"Hans Leidekker"  wrote:
> +BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname,
> - LPSTR computername, LPDWORD size)
> - for (i = 0; i <= len; i++)
> -
>    computername[i] = toupper(hostname[i]);

You can't use toupper() from glibc on a name in a Windows encoding.
Why not just call a W version to do the job?

KERNEL: improve stubs for DnsHostnameToComputerName{A,W} (RESEND)

[Alexandre Julliard]

"Dmitry Timoshkov"  writes:
> "Hans Leidekker"  wrote:
> > +BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname,
> > - LPSTR computername, LPDWORD size)
> > - for (i = 0; i <= len; i++)
> > -
> >    computername[i] = toupper(hostname[i]);
>
> You can't use toupper() from glibc on a name in a Windows encoding.
> Why not just call a W version to do the job?

Actually, why do you want to convert to uppercase at all?  Is there
really an app that breaks if computer name contains lowercase chars?