Hello Gal,
there is no point in adding new resources in English to the other languages rc files. If a resource doesn't exist Win32 will automatically fail over to use the en_US version.
Actually its even detrimental to add the new resources as: a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ cannot show those resources as untranslated. b.) The copied English resources have a tendency to bit-rot. c.) The patch is smaller and offers the exact same functionality.
You need to only amend existing resources in the language files that have that resource. To make it easy the Wine wrc supports the --verify-translation switch. Just take the wrc command that make is running in that directory and append --verify-translation to it. Do that before and after you applied your patch. If you see additional lines popping up that start with "DIFF" or "ERR" your patch breaks the translations and you'll have to check what resource you need to amend.
Gal Topper wrote:
dlls/comdlg32/cdlg_Bg.rc | 38 +++++++ dlls/comdlg32/cdlg_Cs.rc | 38 +++++++ dlls/comdlg32/cdlg_Da.rc | 38 +++++++ dlls/comdlg32/cdlg_De.rc | 38 +++++++ dlls/comdlg32/cdlg_El.rc | 38 +++++++ dlls/comdlg32/cdlg_En.rc | 38 +++++++ dlls/comdlg32/cdlg_Eo.rc | 38 +++++++ dlls/comdlg32/cdlg_Es.rc | 38 +++++++ dlls/comdlg32/cdlg_Fi.rc | 38 +++++++ dlls/comdlg32/cdlg_Fr.rc | 38 +++++++ dlls/comdlg32/cdlg_It.rc | 38 +++++++ dlls/comdlg32/cdlg_Ja.rc | 38 +++++++ dlls/comdlg32/cdlg_Ko.rc | 38 +++++++ dlls/comdlg32/cdlg_Nl.rc | 38 +++++++ dlls/comdlg32/cdlg_No.rc | 38 +++++++ dlls/comdlg32/cdlg_Pl.rc | 38 +++++++ dlls/comdlg32/cdlg_Pt.rc | 85 +++++++++++++++ dlls/comdlg32/cdlg_Ro.rc | 40 +++++++ dlls/comdlg32/cdlg_Ru.rc | 38 +++++++ dlls/comdlg32/cdlg_Si.rc | 38 +++++++ dlls/comdlg32/cdlg_Sk.rc | 38 +++++++ dlls/comdlg32/cdlg_Sv.rc | 38 +++++++ dlls/comdlg32/cdlg_Th.rc | 38 +++++++ dlls/comdlg32/cdlg_Tr.rc | 38 +++++++ dlls/comdlg32/cdlg_Uk.rc | 38 +++++++ dlls/comdlg32/cdlg_Zh.rc | 38 +++++++ dlls/comdlg32/printdlg.c | 269 +++++++++++++++++++++++++++++++++++++++++++++- dlls/comdlg32/printdlg.h | 20 ++++- 28 files changed, 1323 insertions(+), 3 deletions(-)
bye michael
Thanks so much. I wish I had that info earlier so that I wouldn't have had to edit all these resources by hand. :-)
-Gal
On Thu, Sep 18, 2008 at 3:58 AM, Michael Stefaniuc mstefani@redhat.com wrote:
Hello Gal,
there is no point in adding new resources in English to the other languages rc files. If a resource doesn't exist Win32 will automatically fail over to use the en_US version.
Actually its even detrimental to add the new resources as: a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ cannot show those resources as untranslated. b.) The copied English resources have a tendency to bit-rot. c.) The patch is smaller and offers the exact same functionality.
You need to only amend existing resources in the language files that have that resource. To make it easy the Wine wrc supports the --verify-translation switch. Just take the wrc command that make is running in that directory and append --verify-translation to it. Do that before and after you applied your patch. If you see additional lines popping up that start with "DIFF" or "ERR" your patch breaks the translations and you'll have to check what resource you need to amend.
Gal Topper wrote:
dlls/comdlg32/cdlg_Bg.rc | 38 +++++++ dlls/comdlg32/cdlg_Cs.rc | 38 +++++++ dlls/comdlg32/cdlg_Da.rc | 38 +++++++ dlls/comdlg32/cdlg_De.rc | 38 +++++++ dlls/comdlg32/cdlg_El.rc | 38 +++++++ dlls/comdlg32/cdlg_En.rc | 38 +++++++ dlls/comdlg32/cdlg_Eo.rc | 38 +++++++ dlls/comdlg32/cdlg_Es.rc | 38 +++++++ dlls/comdlg32/cdlg_Fi.rc | 38 +++++++ dlls/comdlg32/cdlg_Fr.rc | 38 +++++++ dlls/comdlg32/cdlg_It.rc | 38 +++++++ dlls/comdlg32/cdlg_Ja.rc | 38 +++++++ dlls/comdlg32/cdlg_Ko.rc | 38 +++++++ dlls/comdlg32/cdlg_Nl.rc | 38 +++++++ dlls/comdlg32/cdlg_No.rc | 38 +++++++ dlls/comdlg32/cdlg_Pl.rc | 38 +++++++ dlls/comdlg32/cdlg_Pt.rc | 85 +++++++++++++++ dlls/comdlg32/cdlg_Ro.rc | 40 +++++++ dlls/comdlg32/cdlg_Ru.rc | 38 +++++++ dlls/comdlg32/cdlg_Si.rc | 38 +++++++ dlls/comdlg32/cdlg_Sk.rc | 38 +++++++ dlls/comdlg32/cdlg_Sv.rc | 38 +++++++ dlls/comdlg32/cdlg_Th.rc | 38 +++++++ dlls/comdlg32/cdlg_Tr.rc | 38 +++++++ dlls/comdlg32/cdlg_Uk.rc | 38 +++++++ dlls/comdlg32/cdlg_Zh.rc | 38 +++++++ dlls/comdlg32/printdlg.c | 269 +++++++++++++++++++++++++++++++++++++++++++++- dlls/comdlg32/printdlg.h | 20 ++++- 28 files changed, 1323 insertions(+), 3 deletions(-)
bye michael
On Do, 2008-09-18 at 09:58 +0200, Michael Stefaniuc wrote:
there is no point in adding new resources in English to the other languages rc files. If a resource doesn't exist Win32 will automatically fail over to use the en_US version.
According to julliard a while ago, this is not the case. Strings for sure will not fallback, when a group is present, but incomplete. (The last digit of the resource-id is the index in the group) For dialogs, I'm not sure, how large the group is.
Actually its even detrimental to add the new resources as: a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ cannot show those resources as untranslated.
That's a known missing feature
b.) The copied English resources have a tendency to bit-rot.
That's a known risk.
c.) The patch is smaller and offers the exact same functionality.
Smaller: Yes Same functionality: Not always
Detlef Riekenberg wrote:
On Do, 2008-09-18 at 09:58 +0200, Michael Stefaniuc wrote:
there is no point in adding new resources in English to the other languages rc files. If a resource doesn't exist Win32 will automatically fail over to use the en_US version.
According to julliard a while ago, this is not the case. Strings for sure will not fallback, when a group is present, but incomplete. (The last digit of the resource-id is the index in the group) For dialogs, I'm not sure, how large the group is.
Dialogs are one resource. Stringtables are the oddballs as 16 strings form a resource. I was talking of adding new resources and explicitly not amending existing ones. And the patch was adding 2 new dialogs so there was no point of confusing Gal with the stringtables as those weren't part of the patch.
Actually its even detrimental to add the new resources as: a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ cannot show those resources as untranslated.
That's a known missing feature
A missing feature for which there is *no* complete solution. There are small resources with only 1-2 strings to translate. E.g. a lot of languages took over "Ok". Now how do you decide if that is untranslated or if the translation happens to be the exact same as the en_US version?
b.) The copied English resources have a tendency to bit-rot.
That's a known risk.
For no added benefit. I have thrown away such bit-rotted resources instead of fixing them and Alexandre accepted those patches.
c.) The patch is smaller and offers the exact same functionality.
Smaller: Yes Same functionality: Not always
You are right; the smaller patch has always the better functionality. The stringtables being the exception here but that's why I recommended to use wrc with --verify-translation before and after the patch. If additional DIFF and ERR lines show up one knows that the other language resources need to be updated too. Else don't bother.
bye michael
-
Detlef Riekenberg -
Gal Topper -
Michael Stefaniuc