cmd: fix buffer overflow in WCMD_run_program

[Eric Ho]

Hi Guys,
 I'm a UCLA student working with Dan Kegel on cmd.
 This attached patch adds tests for the following buffer overflows, and
passes on winetestbot.  Fixes http://bugs.winehq.org/show_bug.cgi?id=21344.
Overflows fixed:
1. overflow due to long path name (unchecked memcpy,strcpy to thisDir)
2. overflow due to long file name (unchecked strcpy into stemofsearch)
3. overflow due to concatenating thisDir into stemofsearch (strcat)
4. added early breaks when getFullPathName returns an error
5. fixed incorrect errorlevel code (needs to be 9023 and it was 9009)
-Eric

[Austin English]

On Thu, Mar 4, 2010 at 11:20 AM, Eric Ho  wrote:
> Hi Guys,
>  I'm a UCLA student working with Dan Kegel on cmd.
>  This attached patch adds tests for the following buffer overflows, and
> passes on winetestbot.  Fixes http://bugs.winehq.org/show_bug.cgi?id=21344.
> Overflows fixed:
> - overflow due to long path name (unchecked memcpy,strcpy to thisDir)
> - overflow due to long file name (unchecked strcpy into stemofsearch)
> - overflow due to concatenating thisDir into stemofsearch (strcat)
> - added early breaks when getFullPathName returns an error
> - fixed incorrect errorlevel code (needs to be 9023 and it was 9009)

Howdy Eric,

Patches should be sent to [e-mail]. wine-devel is for
questions/discussion, or for feedback on patches.

[Detlef Riekenberg]

On Do, 2010-03-04 at 09:20 -0800, Eric Ho wrote:
Hi Eric.
Welcome to Wine.
> Fixes http://bugs.winehq.org/show_bug.cgi?id=21344.  Overflows fixed:
> - overflow due to long path name (unchecked memcpy,strcpy to thisDir)
> - overflow due to long file name (unchecked strcpy into stemofsearch)
> - overflow due to concatenating thisDir into stemofsearch (strcat)
> - added early breaks when getFullPathName returns an error
> - fixed incorrect errorlevel code (needs to be 9023 and it was 9009)

Only fix one problem in a patch please.
This list is a good indicator, how to split your patch.
Use [e-mail] for the updated patchset.

Thanks for helping WIne