Missing library - faultrep.

[Peter Dons Tychsen]

Hello.

Wine is missing the library "faultrep".
The library comes with Windows, and is used by apps for error reporting.
Most apps don't really need it (unless something goes wrong), but simply
require the DLL to be present.

To start with i just wanted to add the DLL to Wine.

I tried to submit a patch for this missing lib,
but got zero response. 
Probably because there was something wrong with my commit.

Any guess on what was wrong?

/Pedro

[Alexandre Julliard]

Peter Dons Tychsen  writes:
> I tried to submit a patch for this missing lib,
> but got zero response. 
> Probably because there was something wrong with my commit.
>
> Any guess on what was wrong?

You need to write a proper spec file with all exported functions,
and you need to handle DLL_WINE_PREATTACH in DllMain.

[Peter Dons Tychsen]

On Tue, 2007-08-07 at 17:35 +0200, Alexandre Julliard wrote:
> Peter Dons Tychsen  writes:
> > I tried to submit a patch for this missing lib,
> > but got zero response. 
> > Probably because there was something wrong with my commit.
> >
> > Any guess on what was wrong?
> You need to write a proper spec file with all exported functions,

There are no exported functions (for now). So i guess an empty spec file
is OK ?
> and you need to handle DLL_WINE_PREATTACH in DllMain.

OK, i will add this and re-submit.

/pedro

[Alexandre Julliard]

Peter Dons Tychsen  writes:
> > You need to write a proper spec file with all exported functions,
>
> There are no exported functions (for now). So i guess an empty spec file
> is OK ?

No, there are exported functions in the native dll, you have to
declare them as stubs.

[Peter Dons Tychsen]

On Tue, 2007-08-07 at 23:15 +0200, Alexandre Julliard wrote:
> Peter Dons Tychsen  writes:
> > > You need to write a proper spec file with all exported functions,
> >
> > There are no exported functions (for now). So i guess an empty spec file
> > is OK ?
>
> No, there are exported functions in the native dll, you have to
> declare them as stubs.

Ah... OK, now i get the point.
I will check out the original DLL, and copy the function into the spec.

Thanks,

/pedro