-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
I don't remember and cannot find out from the archives what happened to try 1-3.
+#include "dpnet_private.h"
I think we want our test files to be stand-alone if possible. Having a copy of the code in each file or merging the test files are alternatives to giving up this independence. Though at least dlls/ntdll/tests/ntdll_test.h is an example of an existing test header.
Another option is to generalize this function beyond dpnet.dll and put it in include/wine/test.h or make programs/winetest responsible for checking for stubs. I think programs/winetest is the best place, as it also handles missing DLLs.
If you keep the header please rename it, along with the protection define.
+extern BOOL IsStubDLL(const char *filename) DECLSPEC_HIDDEN;
You have CamelCase in there. You could also consider making this a static inline function in the header, that way you avoid dependencies between the .c files.
+/* + * Windows 8 has a concept of stub DLL's. When DLLMain is called the user is prompted
I think DLLs is the correct plural, DLL's would be the possessive.
LPSTR data = HeapAlloc(GetProcessHeap(), 0, size);
LPFOO. There are other cases on this code.
if (VerQueryValueA(data,"\StringFileInfo\040904b0\OriginalFilename", (LPVOID*)&p, &size))
What's 040904b0? I could not find an explanation on google, so maybe there's no way to avoid it.
Cheers, Stefan
-
Stefan Dösinger