We don't need them in importlib. We use them only for vulkan-1 forwarding, which doesn't need an importlib.
Signed-off-by: Jacek Caban jacek@codeweavers.com --- dlls/winevulkan/make_vulkan | 6 +- dlls/winevulkan/winevulkan.spec | 360 ++++++++++++++++++++-------------------- 2 files changed, 183 insertions(+), 183 deletions(-)
Hi Jacek,
Why are you marking the ICD functions as private? This would break native vulkan-1 support, which requires these calls.
Also for more details see on ICD functions and the different versions. These days only "vk_" ones are needed (though for really old applications using old loader versions a few more as well).
Thanks, Roderick
On Fri, Jul 27, 2018 at 6:31 AM, Jacek Caban jacek@codeweavers.com wrote:
We don't need them in importlib. We use them only for vulkan-1 forwarding, which doesn't need an importlib.
Signed-off-by: Jacek Caban jacek@codeweavers.com
dlls/winevulkan/make_vulkan | 6 +- dlls/winevulkan/winevulkan.spec | 360 ++++++++++++++++++++-------------------- 2 files changed, 183 insertions(+), 183 deletions(-)
On 07/27/2018 04:38 PM, Roderick Colenbrander wrote:
Hi Jacek,
Why are you marking the ICD functions as private? This would break native vulkan-1 support, which requires these calls.
I'm adding a reason for winevulkan to be linked by winelib applications in patch 1/2. Such applications shouldn't be linking to any of ICD nor wine_* functions.
Note that -private means only that they will not be exposed by importlib. Those functions will still be exported by name by DLL and vulkan-1 may still forward to them. Do you expect that we will want to call them by name from C code outside winevulkan in the future? If yes, then we can drop this patch.
Thanks, Jacek
Thanks for clarification. I meant vk_ icd specific calls. Was early in the morning. The wine_ calls obviously need to be internal. Okay so if private means windows dolls can still call then that's fine then.
On Fri, Jul 27, 2018, 7:46 AM Jacek Caban jacek@codeweavers.com wrote:
On 07/27/2018 04:38 PM, Roderick Colenbrander wrote:
Hi Jacek,
Why are you marking the ICD functions as private? This would break native vulkan-1 support, which requires these calls.
I'm adding a reason for winevulkan to be linked by winelib applications in patch 1/2. Such applications shouldn't be linking to any of ICD nor wine_* functions.
Note that -private means only that they will not be exposed by importlib. Those functions will still be exported by name by DLL and vulkan-1 may still forward to them. Do you expect that we will want to call them by name from C code outside winevulkan in the future? If yes, then we can drop this patch.
Thanks, Jacek
-
Jacek Caban -
Józef Kucia -
Roderick Colenbrander