[PATCH] msi/tests: Use the correct ODBC driver name

[Alistair Leslie-Hughes]

The msi installer creates an ODBC driver of "ODBC test driver" which
is never referenced.  Let's create a DSN which points to a
valid driver.

This highlights that msi ignore's errors when registering DSN's.

Signed-off-by: Alistair Leslie-Hughes 
---
 dlls/msi/tests/action.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c
index c0d67c343e..662db2a416 100644
--- a/dlls/msi/tests/action.c
+++ b/dlls/msi/tests/action.c
@@ -1034,7 +1034,7 @@ static const char odbc_datasource_dat[] =
     "DataSource\tComponent_\tDescription\tDriverDescription\tRegistration\n"
     "s72\ts72\ts255\ts255\ti2\n"
     "ODBCDataSource\tDataSource\n"
-    "ODBC data source\todbc\tODBC data source\tODBC driver\t0\n";
+    "ODBC data source\todbc\tODBC data source\tODBC test driver\t0\n";

static const char odbc_install_exec_seq_dat[] =
     "Action\tCondition\tSequence\n"

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=55863

Your paranoid android.

=== w2003std (task log) ===

Task errors:
The task timed out

=== wvistau64 (task log) ===

Task errors:
The task timed out

=== wvistau64_zh_CN (task log) ===

Task errors:
The task timed out

=== wvistau64_fr (task log) ===

Task errors:
The task timed out

=== wvistau64_he (task log) ===

Task errors:
The task timed out

=== w7u (32 bit report) ===

msi:
action: Timeout

=== w7pro64 (task log) ===

Task errors:
The task timed out

=== w1064v1507 (32 bit report) ===

msi:
action: Timeout

=== wvistau64 (task log) ===

Task errors:
The task timed out

=== w7pro64 (64 bit report) ===

msi:
action: Timeout

=== w1064v1507 (64 bit report) ===

msi:
action: Timeout

[Hans Leidekker]

On Tue, 2019-08-27 at 05:50 +0000, Alistair Leslie-Hughes wrote:
> The msi installer creates an ODBC driver of "ODBC test driver" which
> is never referenced.  Let's create a DSN which points to a
> valid driver.

According to the documentation it doesn't have to be a pre-existing
driver. Even if you correct the driver name the test file is still not
a valid ODBC setup dll, which is also ignored apparently.

I think it would be better to make msi warn but succeed when
SQLConfigDataSource fails.