And some other problems with the patch:
"Damjan Jovanovic" damjan.jov@gmail.com wrote:
--- a/include/winbase.h 2007-01-09 17:42:47.000000000 +0200 +++ b/include/winbase.h 2007-01-24 09:50:04.000000000 +0200 @@ -2343,6 +2343,14 @@
#endif /* __i386__ && __GNUC__ && __WINESRC__ && !_NTSYSTEM_ */
+#if (_WIN32_WINNT >= 0x0501) +VOID WINAPI InitializeSListHead(PSLIST_HEADER); +USHORT WINAPI QueryDepthSList(PSLIST_HEADER); +PSLIST_ENTRY WINAPI InterlockedFlushSList(PSLIST_HEADER); +PSLIST_ENTRY WINAPI InterlockedPopEntrySList(PSLIST_HEADER); +PSLIST_ENTRY WINAPI InterlockedPushEntrySList(PSLIST_HEADER,PSLIST_ENTRY); +#endif
Usually Wine doesn't use and doesn't need the checks for _WIN32_WINNT and similar macros. There are a couple of violations to that rule, but they need to be fixed.
libs/port/interlocked.c changes should be sent separately, please remove c++ comments from them first.