Re: Fix the FIXME message to reflect the real problem.

[Piotr Caban]

On 06/02/12 13:35, [e-mail] wrote:
> @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal(
>               goto cleanup;
>           }
> -
>    FIXME("entry already in cache - don't know what to do!\n");
> -
>    FIXME("collision handler needed - the entry is already in use!\n");

This message is not about entry being used. I think the old message is 
quite accurate. The "don't know what to do" part is quite strange but I 
don't see reason to change it.

Fix the FIXME message to reflect the real problem.

[Juan Lang]

On Mon, Jun 4, 2012 at 2:19 AM, Piotr Caban  wrote:
> On 06/02/12 13:35, [e-mail] wrote:
> > @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal(
> >              goto cleanup;
> >          }
> > - FIXME("entry already in cache - don't know what to do!\n");
> > - FIXME("collision handler needed - the entry is already in
> >
> > use!\n");
>
> This message is not about entry being used. I think the old message is quite
> accurate. The "don't know what to do" part is quite strange but I don't see
> reason to change it.

I agree.  The reason we get these all the time is that we never
fulfill requests from cache, but we do write to the cache, so for all
potential cache hits, we write duplicate cache entries.  After 4
entries have been written, we begin to see the fixme.

If this message is annoying, it's working: we need to start fulfilling
requests from cache, instead of just filling up users' hard drives.
--Juan