Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib (Try 3, resend)

[Nikolay Sivov]

On 12/20/2012 14:50, Tatyana Fokina wrote:

Hi, Tatyana.

Main problem is that your test will crash if run without patch 2/2, 
that's not how it should be done.
You need to merge these patches together to keep tests working or send 
implementation fix first,
so next test patch will work.
> - hr = ITypeInfo2_GetContainingTypeLib(ti2, (ITypeLib **)&tl, &Index);
> - ok(hr == S_OK, " ITypeInfo2_GetContainingTypeLib failed on Index\n");
> - if(tl) ITypeLib_Release(tl);

You don't need a cast here.
> - hr = ITypeInfo2_GetContainingTypeLib(ti2, NULL, &Index);
> - ok(hr == S_OK, " ITypeInfo2_GetContainingTypeLib failed on ITypeLib = NULL\n");

Please test index value here and above to make sure it really returns 
something.