Re: [PATCH] ucrtbase: Implement vsscanf

[Piotr Caban]

On 10/28/15 09:54, Martin Storsjo wrote:
> +/*********************************************************************
> -
> -
> _snscanf_s_l (MSVCRT.@)
> - */
>
> +int CDECL MSVCRT__stdio_common_vsscanf(unsigned __int64 options, const char *input, MSVCRT_size_t length, const char *format, MSVCRT__locale_t locale, __ms_va_list valist)
> +{
> - return MSVCRT_vsnscanf_l(input, length, format, locale, valist);
>
> +}

Shouldn't this function also print some message about ignored options 
argument?

Thanks,
Piotr

[PATCH] ucrtbase: Implement vsscanf

[Martin Storsjö]

On Wed, 28 Oct 2015, Piotr Caban wrote:
> On 10/28/15 09:54, Martin Storsjo wrote:
> > +/*********************************************************************
> > -
> > -
> > _snscanf_s_l (MSVCRT.@)
> > - */
> >
> > +int CDECL MSVCRT__stdio_common_vsscanf(unsigned __int64 options, const 
> > char *input, MSVCRT_size_t length, const char *format, MSVCRT__locale_t 
> > locale, __ms_va_list valist)
> > +{
> > - return MSVCRT_vsnscanf_l(input, length, format, locale, valist);
> >
> > +}
>
> Shouldn't this function also print some message about ignored options 
> argument?

I guess so; currently it implements the legacy mode. I'll add a FIXME if 
used with any other options, and later look into completing support for 
the new, standards compliant mode.

// Martin

[PATCH] ucrtbase: Implement vsscanf

[Piotr Caban]

Hi,

On 10/28/15 22:59, Martin Storsjö wrote:
> > > +int CDECL MSVCRT__stdio_common_vsscanf(unsigned __int64 options,
> > > const char *input, MSVCRT_size_t length, const char *format,
> > > MSVCRT__locale_t locale, __ms_va_list valist)

Sorry for not asking about it earlier but could you please avoid adding 
long lines. It's not a hard limit but in general we're trying to use up 
to 80-characters in line. It's OK to have longer lines if it makes code 
more readable but I think you should try to not exceed e.g. 120 
characters in line (if there's a good reason I'm OK with longer lines).

Except of it the patch looks good for me.

Thanks,
Piotr

[PATCH] ucrtbase: Implement vsscanf

[Martin Storsjö]

On Thu, 29 Oct 2015, Piotr Caban wrote:
> Hi,
>
> On 10/28/15 22:59, Martin Storsjö wrote:
> > > > +int CDECL MSVCRT__stdio_common_vsscanf(unsigned __int64 options,
> > > > const char *input, MSVCRT_size_t length, const char *format,
> > > > MSVCRT__locale_t locale, __ms_va_list valist)
>
> Sorry for not asking about it earlier but could you please avoid adding long 
> lines. It's not a hard limit but in general we're trying to use up to 
> 80-characters in line. It's OK to have longer lines if it makes code more 
> readable but I think you should try to not exceed e.g. 120 characters in line 
> (if there's a good reason I'm OK with longer lines).

Ok, will repost with that fixed. Apparently I did at least some 
rudimentary wrapping of the lines for the printf functions, but not 
here...

// Martin