Re: [1/10] Check for ms_hook_prologue attribute support, make a first function hookable

[Dmitry Timoshkov]

"Stefan Dösinger"  wrote:
> -HRESULT WINAPI DirectInput8Create(HINSTANCE hinst, DWORD dwVersion, REFIID riid, LPVOID *ppDI, LPUNKNOWN punkOuter) {
> +HRESULT WINAPI DECLSPEC_HOTPATCH DirectInput8Create(HINSTANCE hinst, DWORD dwVersion, REFIID riid, LPVOID *ppDI, 
> LPUNKNOWN punkOuter) {

Probably DECLSPEC_HOTPATCH just should be a part of WINAPI.

[1/10] Check for ms_hook_prologue attribute support, make a first function hookable

[Stefan Dösinger]

Am 14.10.2009 um 05:42 schrieb Dmitry Timoshkov:
> "Stefan Dösinger"  wrote:
> > -HRESULT WINAPI DirectInput8Create(HINSTANCE hinst, DWORD  
> > dwVersion, REFIID riid, LPVOID *ppDI, LPUNKNOWN punkOuter) {
> > +HRESULT WINAPI DECLSPEC_HOTPATCH DirectInput8Create(HINSTANCE  
> > hinst, DWORD dwVersion, REFIID riid, LPVOID *ppDI, LPUNKNOWN  
> > punkOuter) {
>
> Probably DECLSPEC_HOTPATCH just should be a part of WINAPI.

I suggested that as well, Alexandre disagreed. Windows doesn't make  
all functions hotpatchable either. I don't know if that is  
intentional, or just a bug due to the way /hotpatch works, or doesn't  
work, with optimization.