Re: qcap: Define O_CLOEXEC when needed (try 2)

[Sebastian Lackner]

On 21.02.2017 00:21, André Hentschel wrote:
> Signed-off-by: André Hentschel
>
> https://bugs.winehq.org/show_bug.cgi?id=42478
> Thanks Bruno for the note on octal
>
> dlls/qcap/v4l.c             |  4 +++
>  dlls/setupapi/devinst.c     | 71 +++++++++++++++++++++++++++++++++++++++++++++
>  dlls/setupapi/dialog.c      |  2 ++
>  dlls/setupapi/dirid.c       |  2 ++
>  dlls/setupapi/diskspace.c   | 10 +++++++
>  dlls/setupapi/install.c     | 10 +++++++
>  dlls/setupapi/misc.c        | 42 +++++++++++++++++++++++++++
>  dlls/setupapi/parser.c      | 27 +++++++++++++++++
>  dlls/setupapi/query.c       | 12 ++++++++
>  dlls/setupapi/queue.c       | 44 ++++++++++++++++++++++++++++
>  dlls/setupapi/setupcab.c    |  2 ++
>  dlls/setupapi/stringtable.c | 13 +++++++++
>  dlls/setupapi/stubs.c       | 63 ++++++++++++++++++++++++++++++++++++++++
>  13 files changed, 302 insertions(+)

It looks like you added various unrelated changes.

Also, defining O_CLOEXEC will have no effect when its not supported by the operating
system. We could use fcntl( fd, F_SETFD, FD_CLOEXEC ); as a portable way to set
close-on-exec for all platforms.

qcap: Define O_CLOEXEC when needed (try 2)

[André Hentschel]

Am 21.02.2017 um 00:51 schrieb Sebastian Lackner:
> On 21.02.2017 00:21, André Hentschel wrote:
> > Signed-off-by: André Hentschel
> >
> > https://bugs.winehq.org/show_bug.cgi?id=42478
> > Thanks Bruno for the note on octal
> >
> > dlls/qcap/v4l.c             |  4 +++
> >  dlls/setupapi/devinst.c     | 71 +++++++++++++++++++++++++++++++++++++++++++++
> >  dlls/setupapi/dialog.c      |  2 ++
> >  dlls/setupapi/dirid.c       |  2 ++
> >  dlls/setupapi/diskspace.c   | 10 +++++++
> >  dlls/setupapi/install.c     | 10 +++++++
> >  dlls/setupapi/misc.c        | 42 +++++++++++++++++++++++++++
> >  dlls/setupapi/parser.c      | 27 +++++++++++++++++
> >  dlls/setupapi/query.c       | 12 ++++++++
> >  dlls/setupapi/queue.c       | 44 ++++++++++++++++++++++++++++
> >  dlls/setupapi/setupcab.c    |  2 ++
> >  dlls/setupapi/stringtable.c | 13 +++++++++
> >  dlls/setupapi/stubs.c       | 63 ++++++++++++++++++++++++++++++++++++++++
> >  13 files changed, 302 insertions(+)
>
> It looks like you added various unrelated changes.

yes, oops
did too many things at once late at night...
> Also, defining O_CLOEXEC will have no effect when its not supported by the operating
> system. We could use fcntl( fd, F_SETFD, FD_CLOEXEC ); as a portable way to set
> close-on-exec for all platforms.

OK, guess I'll leave your idea up to you :)