Re: [PATCH 1/11] apphelp: Add definitions.

[Alexandre Julliard]

Mislav Blazevic  writes:
> @@ -25,6 +26,209 @@ extern "C" {
>
> BOOL WINAPI ApphelpCheckShellObject(REFCLSID, BOOL, ULONGLONG *);
>
> +typedef enum _PATH_TYPE {
> - DOS_PATH,
> - NT_PATH
>
> +} PATH_TYPE;
> -
>
> +typedef struct _DB {
> - HANDLE file;
> - DWORD size;
> - PBYTE data;
>
> +} DB, *PDB;
> -
>
> +typedef DWORD TAGID;
> +typedef WORD TAG;
> -
>
> +#define TAGID_NULL 0x0
> +#define TAGID_ROOT 0x0
> -
>
> +/* The above definition of TAGID_ROOT is used in winapi but doesn't make
> -
> - sense, especially internally, because TAGID represents offset into
> -
> - database data and there is a header at offset 0, NOT a tag.
> -
> - Therfore, this definition should only be used internally. */
>
> +#define _TAGID_ROOT 0xC

If it's internal it shouldn't be in the public header. In fact I don't
see any of these definitions in the SDK header.