wine_dbgstr_w() already quotes the string.
Signed-off-by: Francois Gouget fgouget@codeweavers.com --- dlls/gameux/tests/gamestatistics.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index 8d4da4a0f4c..192a245e096 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -295,17 +295,17 @@ static void test_gamestatisticsmgr( void ) /* verify values with these which we stored before*/ hr = IGameStatistics_GetCategoryTitle(gs, 0, &lpName); ok(hr == S_OK, "getting category title failed\n"); - ok(lstrcmpW(lpName, sCategory0)==0, "getting category title returned invalid string (%s)\n", wine_dbgstr_w(lpName)); + ok(lstrcmpW(lpName, sCategory0)==0, "getting category title returned invalid string %s\n", wine_dbgstr_w(lpName)); CoTaskMemFree(lpName);
hr = IGameStatistics_GetCategoryTitle(gs, 1, &lpName); ok(hr == S_OK, "getting category title failed\n"); - ok(lstrcmpW(lpName, sCategory1)==0, "getting category title returned invalid string (%s)\n", wine_dbgstr_w(lpName)); + ok(lstrcmpW(lpName, sCategory1)==0, "getting category title returned invalid string %s\n", wine_dbgstr_w(lpName)); CoTaskMemFree(lpName);
hr = IGameStatistics_GetCategoryTitle(gs, 2, &lpName); ok(hr == S_OK, "getting category title failed\n"); - ok(lstrcmpW(lpName, sCategory2)==0, "getting category title returned invalid string (%s)\n", wine_dbgstr_w(lpName)); + ok(lstrcmpW(lpName, sCategory2)==0, "getting category title returned invalid string %s\n", wine_dbgstr_w(lpName)); CoTaskMemFree(lpName);
/* check result if category doesn't exists */
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=68781
Your paranoid android.
=== w1064v1809 (32 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
=== w1064v1809_2scr (32 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
=== w1064v1809_ar (32 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
=== w1064v1809_he (32 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
=== w1064v1809_ja (32 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
=== w1064v1809_zh_CN (32 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
=== w1064v1809 (64 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
On Thu, 2 Apr 2020, Marvin wrote: [...]
=== w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === === w1064v1809_ja (32 bit report) === === w1064v1809_zh_CN (32 bit report) === === w1064v1809 (64 bit report) ===
gameux: gamestatistics.c:298: Test failed: getting category title returned invalid string (null) gamestatistics.c:303: Test failed: getting category title returned invalid string (null) gamestatistics.c:308: Test failed: getting category title returned invalid string (null)
These are preexisting Windows 10 1809+ failures and the reason why I made this patch: before it the invalid string was shown as ((null)).
https://test.winehq.org/data/tests/gameux:gamestatistics.html
I noticed those when I checked whether the '((...))' pattern already occurred in the current test failures and this is the only place where it did.
-
Francois Gouget -
Marvin